From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=32817 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PGwlQ-0003RN-TW
	for qemu-devel@nongnu.org; Fri, 12 Nov 2010 11:46:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PGwlP-00016S-JK
	for qemu-devel@nongnu.org; Fri, 12 Nov 2010 11:46:12 -0500
Received: from mx1.redhat.com ([209.132.183.28]:12318)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PGwlP-000163-C8
	for qemu-devel@nongnu.org; Fri, 12 Nov 2010 11:46:11 -0500
Message-ID: <4CDD6F78.2030604@redhat.com>
Date: Fri, 12 Nov 2010 17:46:48 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0/2] v7 Decouple block device removal from
	device removal
References: <1289576289-27888-1-git-send-email-ryanh@us.ibm.com>
	<m3fwv6bj69.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3fwv6bj69.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Stefan Hajnoczi <stefan.hajnoczi@uk.ibm.com>, Anthony Liguori <aliguori@linux.vnet.ibm.com>, Ryan Harper <ryanh@us.ibm.com>, qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

Am 12.11.2010 17:28, schrieb Markus Armbruster:
> Ryan Harper <ryanh@us.ibm.com> writes:
> 
>> Once more dear friends, v7
>>
>> This patch series decouples the detachment of a block device from the
>> removal of the backing pci-device.  Removal of a hotplugged pci device
>> requires the guest to respond before qemu tears down the block device.
>> In some cases, the guest may not respond leaving the guest with
>> continued access to the block device.  Mgmt layer doesn't have a
>> reliable method to force a disconnect.  
>>
>> The new monitor command, drive_del, will revoke a guests access to the
>> block device independently of the removal of the pci device.
>>
>> The first patch implements drive_del, the second patch implements the
>> qmp version of the monitor command.
>>
>> Changes since v6:
>> - Updated patch description
>> - Dropped bdrv_unplug and inlined in drive_del
>> - Explicitly invoke drive_uninit()
>> Changes since v5:
>> - Removed dangling pointers in guest and host state.  This ensures things like 
>>   info block no longer displays the deleted drive; though info pci will
>>   continue to display the pci device until the guest responds to the removal
>>   request.
>> - Renamed drive_unplug -> drive_del
>> Changes since v4:
>> - Droppped drive_get_by_id patch and use bdrv_find() instead
>> - Added additional details about drive_unplug to hmp/qmp interface
>>
>> Changes since v3:
>> - Moved QMP command for drive_unplug() to separate patch
>>
>> Changes since v2:
>> - Added QMP command for drive_unplug()
>>
>> Changes since v1:
>> - CodingStyle fixes
>> - Added qemu_aio_flush() to bdrv_unplug()
>>
>> Signed-off-by: Ryan Harper <ryanh@us.ibm.com>
> 
> ACK series

I have to admit that I didn't follow your discussion very closely any
more after a few versions, so just to confirm: You came to the
conclusion that we want to add drive_del to QMP and not only the human
monitor, even though there is no drive_add in QMP?

The HMP help text doesn't seem to be completely right (sent a comment),
but once that's fixed, I'm going to merge the series based on Markus's ACK.

Kevin