From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=35523 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PGxVy-0004EE-CO
	for qemu-devel@nongnu.org; Fri, 12 Nov 2010 12:34:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PGxVx-00020K-FQ
	for qemu-devel@nongnu.org; Fri, 12 Nov 2010 12:34:18 -0500
Received: from mx1.redhat.com ([209.132.183.28]:3661)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PGxVx-000207-6W
	for qemu-devel@nongnu.org; Fri, 12 Nov 2010 12:34:17 -0500
Message-ID: <4CDD7AB8.1010806@redhat.com>
Date: Fri, 12 Nov 2010 18:34:48 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH v4 2/5] qed: Add QEMU Enhanced Disk image
	format
References: <1288263684-18892-1-git-send-email-stefanha@linux.vnet.ibm.com>	<1288263684-18892-3-git-send-email-stefanha@linux.vnet.ibm.com>	<4CDD6085.8020007@redhat.com>	<AANLkTi=eRVsJ=mzeDFJ6FHOPuHPa+uLaLCJ8gE-DpBEM@mail.gmail.com>	<4CDD70BA.60504@redhat.com>
	<m3vd425uaq.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3vd425uaq.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>, Christoph Hellwig <hch@lst.de>

Am 12.11.2010 18:24, schrieb Markus Armbruster:
> Kevin Wolf <kwolf@redhat.com> writes:
> 
>> Am 12.11.2010 17:34, schrieb Stefan Hajnoczi:
>>> On Fri, Nov 12, 2010 at 3:43 PM, Kevin Wolf <kwolf@redhat.com> wrote:
>>>> Am 28.10.2010 13:01, schrieb Stefan Hajnoczi:
>>>>> +/**
>>>>> + * Check whether an image format is raw
>>>>> + *
>>>>> + * @fmt:    Backing file format, may be NULL
>>>>> + */
>>>>> +static bool qed_fmt_is_raw(const char *fmt)
>>>>> +{
>>>>> +    return fmt && strcmp(fmt, "raw") == 0;
>>>>> +}
>>>>
>>>> People shouldn't use them directly, but should we also consider file,
>>>> host_device, etc.?
>>>
>>> Hrm..I will look into it for v5.  I thought we always have a "raw"
>>> format on top of "file", "host_device", etc protocols?
>>
>> That's how it's meant to be used. I think at the moment we still allow
>> to directly use file etc. and you know that if something is possible,
>> users will do it.
> 
> It's possible, it's perfectly well-defined, and it works.

Wow, I'm not used to be confirmed that quickly!

Yes, it's possible, it works, but it's only exposed because we didn't
pay attention when host_* was split out. There's no real reason to use
it (or do you have any example where format=raw doesn't work?) and it
should be considered an implementation detail.

Kevin