From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=38754 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PGxZs-0006cg-S9
	for qemu-devel@nongnu.org; Fri, 12 Nov 2010 12:38:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PGxZr-0002de-Kv
	for qemu-devel@nongnu.org; Fri, 12 Nov 2010 12:38:20 -0500
Received: from mx1.redhat.com ([209.132.183.28]:1027)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PGxZr-0002dQ-CW
	for qemu-devel@nongnu.org; Fri, 12 Nov 2010 12:38:19 -0500
Message-ID: <4CDD7BB1.5060504@redhat.com>
Date: Fri, 12 Nov 2010 18:38:57 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1289581634-21177-1-git-send-email-ryanh@us.ibm.com>
In-Reply-To: <1289581634-21177-1-git-send-email-ryanh@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 0/2] v8 Decouple block device removal from
	device removal
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ryan Harper <ryanh@us.ibm.com>
Cc: Stefan Hajnoczi <stefan.hajnoczi@uk.ibm.com>, Anthony Liguori <aliguori@linux.vnet.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

Am 12.11.2010 18:07, schrieb Ryan Harper:
> details, details, v8
> 
> This patch series decouples the detachment of a block device from the
> removal of the backing pci-device.  Removal of a hotplugged pci device
> requires the guest to respond before qemu tears down the block device.
> In some cases, the guest may not respond leaving the guest with
> continued access to the block device.  Mgmt layer doesn't have a
> reliable method to force a disconnect.  
> 
> The new monitor command, drive_del, will revoke a guests access to the
> block device independently of the removal of the pci device.
> 
> The first patch implements drive_del, the second patch implements the
> qmp version of the monitor command.
> 
> Changes since v7:
> - Fixed up doc strings (delete -> drive_del)
> Changes since v6:
> - Updated patch description
> - Dropped bdrv_unplug and inlined in drive_del
> - Explicitly invoke drive_uninit()
> Changes since v5:
> - Removed dangling pointers in guest and host state.  This ensures things like 
>   info block no longer displays the deleted drive; though info pci will
>   continue to display the pci device until the guest responds to the removal
>   request.
> - Renamed drive_unplug -> drive_del
> Changes since v4:
> - Droppped drive_get_by_id patch and use bdrv_find() instead
> - Added additional details about drive_unplug to hmp/qmp interface
> 
> Changes since v3:
> - Moved QMP command for drive_unplug() to separate patch
> 
> Changes since v2:
> - Added QMP command for drive_unplug()
> 
> Changes since v1:
> - CodingStyle fixes
> - Added qemu_aio_flush() to bdrv_unplug()
> 
> Signed-off-by: Ryan Harper <ryanh@us.ibm.com>

Thanks, applied both to the block branch.

Kevin