From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55979 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PHG6u-0004te-02
	for qemu-devel@nongnu.org; Sat, 13 Nov 2010 08:25:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1PHG6s-0004Qs-Tt
	for qemu-devel@nongnu.org; Sat, 13 Nov 2010 08:25:39 -0500
Received: from moutng.kundenserver.de ([212.227.17.10]:59299)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1PHG6s-0004Py-Hc
	for qemu-devel@nongnu.org; Sat, 13 Nov 2010 08:25:38 -0500
Message-ID: <4CDE91CC.2080509@mail.berlios.de>
Date: Sat, 13 Nov 2010 14:25:32 +0100
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/2] Delete useless 'extern' qualifiers for
	functions
References: <AANLkTimhiFCb7Zhm1NPikKzVsdVWaHTweZRFy6wr=pDi@mail.gmail.com>
In-Reply-To: <AANLkTimhiFCb7Zhm1NPikKzVsdVWaHTweZRFy6wr=pDi@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

Am 13.11.2010 13:49, schrieb Blue Swirl:
> 'extern' qualifier is useless for function declarations. Delete
> them.
>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
> cache-utils.h | 2 +-
> cmd.h | 36 ++++++++--------
> darwin-user/commpage.c | 2 +-
> darwin-user/syscall.c | 24 +++++-----
> dis-asm.h | 85 +++++++++++++++++++--------------------
> envlist.h | 14 +++---
> exec-all.h | 2 +-
> fpu/softfloat-native.c | 4 +-
> fsdev/qemu-fsdev.h | 6 +-
> hw/file-op-9p.h | 2 +-
> hw/hw.h | 21 +++++-----
> hw/mips.h | 2 +-
> hw/s390-virtio-bus.h | 16 +++----
> hw/virtio-9p-xattr.h | 17 ++++----
> hw/virtio-9p.h | 4 +-
> hw/watchdog.h | 8 ++--
> linux-user/arm/nwfpe/fpa11.h | 6 +-
> linux-user/arm/nwfpe/fpopcode.h | 4 +-
> linux-user/syscall.c | 10 ++--
> m68k-dis.c | 11 ++---
> osdep.c | 2 +-
> qemu-common.h | 2 +-
> slirp/slirp.h | 10 ++--
> target-s390x/cpu.h | 6 +-
> tests/cris/sys.h | 4 +-
> tests/runcom.c | 4 +-
> ui/cocoa.m | 6 +-
> ui/d3des.h | 8 ++--
> ui/x_keymap.h | 4 +-
> 29 files changed, 158 insertions(+), 164 deletions(-)

extern qualifiers in *.c files are very useful:

They should be replaced by include statements
(this makes it possible to check whether declaration
and implementation match). Without 'extern', they are
difficult to detect, with 'extern' this is easy.

So either replace those extern declarations by an
include statement (best solution), or don't touch the
'extern' there, or add a comment which can be easily
found (XXX or TODO).

Regards
Stefan