From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=33206 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PHd0y-0006HQ-JM for qemu-devel@nongnu.org; Sun, 14 Nov 2010 08:53:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PHd0x-0001V9-K9 for qemu-devel@nongnu.org; Sun, 14 Nov 2010 08:53:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PHd0x-0001Uy-BE for qemu-devel@nongnu.org; Sun, 14 Nov 2010 08:53:03 -0500 Message-ID: <4CDFE9A5.7000706@redhat.com> Date: Sun, 14 Nov 2010 14:52:37 +0100 From: Paolo Bonzini MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] make trace options use autoconfy names References: <1289735432-8776-1-git-send-email-pbonzini@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: qemu-devel Developers , Stefan Hajnoczi On 11/14/2010 02:38 PM, Andreas F=E4rber wrote: >> - --trace-file=3D*) trace_file=3D"$optarg" >> + --enable-trace-file=3D*) trace_file=3D"$optarg" >> ;; > > but this should be --with-trace-file=3D... please. It is not being > enabled, just set to a different value. --with-* should be reserved for library paths, but I can change it if=20 people prefer it that way. Paolo