From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=51778 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PHxrk-0005u9-9U for qemu-devel@nongnu.org; Mon, 15 Nov 2010 07:08:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PHxre-00084y-2s for qemu-devel@nongnu.org; Mon, 15 Nov 2010 07:08:56 -0500 Received: from thoth.sbs.de ([192.35.17.2]:17644) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PHxrd-00084R-MS for qemu-devel@nongnu.org; Mon, 15 Nov 2010 07:08:50 -0500 Message-ID: <4CE122CC.6050700@siemens.com> Date: Mon, 15 Nov 2010 13:08:44 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1284740181.14301.15.camel@x201> <1289820837-24254-1-git-send-email-bernhard.kohl@nsn.com> In-Reply-To: <1289820837-24254-1-git-send-email-bernhard.kohl@nsn.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] device-assignment: register a reset function List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bernhard Kohl Cc: alex.williamson@redhat.com, Thomas Ostler , kvm , "Michael S. Tsirkin" [Wrong list, it's not upstream yet. I'm migrating the thread to kvm.] Am 15.11.2010 12:33, Bernhard Kohl wrote: > This is necessary because during reboot of a VM the assigned devices > continue DMA transfers which causes memory corruption. > > Signed-off-by: Thomas Ostler > Signed-off-by: Bernhard Kohl > --- > Sorry for for the long delay. Finally we added Alex' suggestions > and rebased the patch. > > Thanks > Bernhard > --- > hw/device-assignment.c | 12 ++++++++++++ > 1 files changed, 12 insertions(+), 0 deletions(-) > > diff --git a/hw/device-assignment.c b/hw/device-assignment.c > index 5f5bde1..3f8de66 100644 > --- a/hw/device-assignment.c > +++ b/hw/device-assignment.c > @@ -1434,6 +1434,17 @@ static void assigned_dev_unregister_msix_mmio(AssignedDevice *dev) > dev->msix_table_page = NULL; > } > > +static void reset_assigned_device(DeviceState *dev) > +{ > + PCIDevice *d = DO_UPCAST(PCIDevice, qdev, dev); > + uint32_t conf; > + > + /* reset the bus master bit to avoid further DMA transfers */ > + conf = assigned_dev_pci_read_config(d, PCI_COMMAND, 2); > + conf &= ~PCI_COMMAND_MASTER; > + assigned_dev_pci_write_config(d, PCI_COMMAND, conf, 2); What about writing to /sys/bus/pci/devices/$DEVICE/reset? You probably still need to put the command word into the reset state (ie. no RMW in any case, just write 0), but the hardware should receive a reset as well - if it is capable of doing a function-level reset, but we should at least try. > +} > + > static int assigned_initfn(struct PCIDevice *pci_dev) > { > AssignedDevice *dev = DO_UPCAST(AssignedDevice, dev, pci_dev); > @@ -1544,6 +1555,7 @@ static PCIDeviceInfo assign_info = { > .qdev.name = "pci-assign", > .qdev.desc = "pass through host pci devices to the guest", > .qdev.size = sizeof(AssignedDevice), > + .qdev.reset = reset_assigned_device, > .init = assigned_initfn, > .exit = assigned_exitfn, > .config_read = assigned_dev_pci_read_config, Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux