From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=40313 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PHybu-00062u-LJ for qemu-devel@nongnu.org; Mon, 15 Nov 2010 07:56:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PHybt-0002e2-Kv for qemu-devel@nongnu.org; Mon, 15 Nov 2010 07:56:38 -0500 Received: from mail-qy0-f173.google.com ([209.85.216.173]:46878) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PHybt-0002dx-FK for qemu-devel@nongnu.org; Mon, 15 Nov 2010 07:56:37 -0500 Received: by qyl33 with SMTP id 33so3811221qyl.4 for ; Mon, 15 Nov 2010 04:56:36 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4CE12DFF.8050109@redhat.com> Date: Mon, 15 Nov 2010 13:56:31 +0100 From: Paolo Bonzini MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH V6 04/15] Introduce -accel command option. References: <1287682587-18642-1-git-send-email-anthony.perard@citrix.com> <1287682587-18642-5-git-send-email-anthony.perard@citrix.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Anthony.Perard@citrix.com, Xen Devel , QEMU-devel Developers , Stefano Stabellini On 11/15/2010 11:46 AM, Alexander Graf wrote: > I take back my Acked-by. Sorry, I guess I should have read things in > more detail first O_o. I still believe that this patch can go in > before the others, but I'd at least like to see some comments on the > (0) pointer thing:). I agree, it kind of works by chance, (0) works but (1) wouldn't. Better to define the function always. Paolo