From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41721 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PI0T6-0000qq-5z for qemu-devel@nongnu.org; Mon, 15 Nov 2010 09:55:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PI0Sd-0005p9-CD for qemu-devel@nongnu.org; Mon, 15 Nov 2010 09:55:36 -0500 Received: from mail-qw0-f45.google.com ([209.85.216.45]:38546) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PI0Sd-0005ou-9z for qemu-devel@nongnu.org; Mon, 15 Nov 2010 09:55:11 -0500 Received: by qwd6 with SMTP id 6so1827qwd.4 for ; Mon, 15 Nov 2010 06:55:10 -0800 (PST) Message-ID: <4CE149CB.1040301@codemonkey.ws> Date: Mon, 15 Nov 2010 08:55:07 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <20101104180406.GA2820@redhat.com> <5f91d600c749e66de107f60298c5ebd36645beff.1288892774.git.mst@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" On 11/15/2010 08:52 AM, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > >> There's no reason for tap to run when VM is stopped. >> If we let it, it confuses the bridge on TX >> and corrupts DMA memory on RX. >> >> Signed-off-by: Michael S. Tsirkin >> > once here, what handlers make sense to run while stopped? > /me can think of the normal console, non live migration, loadvm and not > much more. Perhaps it is easier to just move the other way around? > I'm not sure I concur that this is really a problem. Semantically, I don't think that stop has to imply that the guest memory no longer changes. Regards, Anthony Liguori > Later, Juan. >