From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=48229 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PI1Ih-0002f4-Us for qemu-devel@nongnu.org; Mon, 15 Nov 2010 10:49:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PI1Ic-0001sL-U9 for qemu-devel@nongnu.org; Mon, 15 Nov 2010 10:48:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59432) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PI1Ic-0001sE-NV for qemu-devel@nongnu.org; Mon, 15 Nov 2010 10:48:54 -0500 Message-ID: <4CE1565F.9070105@redhat.com> Date: Mon, 15 Nov 2010 16:48:47 +0100 From: Paolo Bonzini MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] make trace options use autoconfy names References: <1289735432-8776-1-git-send-email-pbonzini@redhat.com> <4CDFE9A5.7000706@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: =?ISO-8859-1?Q?Andreas_F=E4rber?= , qemu-devel Developers , Stefan Hajnoczi On 11/15/2010 03:17 PM, Stefan Hajnoczi wrote: > On Sun, Nov 14, 2010 at 1:52 PM, Paolo Bonzini wr= ote: >> On 11/14/2010 02:38 PM, Andreas F=E4rber wrote: >>>> >>>> - --trace-file=3D*) trace_file=3D"$optarg" >>>> + --enable-trace-file=3D*) trace_file=3D"$optarg" >>>> ;; >>> >>> but this should be --with-trace-file=3D... please. It is not being >>> enabled, just set to a different value. >> >> --with-* should be reserved for library paths, but I can change it if = people >> prefer it that way. > > Actually I think we have something similar to overriding --prefix here > :). It's a path that you can set at ./configure time. Yeah, that's true. However... > So is it not okay to use --trace-file=3D? ... Autoconf would not allow unknown options not starting with --enable-=20 or --with-. The rationale to avoid incompatible options in QEMU is this: suppose you=20 have a project using Autoconf (e.g. GCC) and you want to drop QEMU as a=20 subdirectory in there, e.g. to run the GCC testsuite under QEMU usermode=20 emulation (GCC can already do this for other simulators). To pass=20 options to QEMU's configure, you can include them in GCC's commandline.=20 The script will simply pass the option down to QEMU and it will be=20 processed there. However, if you pass --trace-file to GCC's configure=20 script, it will complain and stop. Probably I would use something like --enable-trace-backend=3Dsimple:trace= -=20 if I was adding something similar to an autoconfiscated project. But=20 unless it provides some additional benefit (as is the case with=20 cross-compilation support) I want to keep the syntactic changes in my=20 patches to the minimum. > But I know nothing of autoconf and --enable-* or --with-* sort of > make sense too. Whatever, I have to repost the other series anyway, so I'll change to=20 --with-. Paolo