From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37812 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PI1kq-0000qY-Ny
	for qemu-devel@nongnu.org; Mon, 15 Nov 2010 11:18:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bernhard.kohl@nsn.com>) id 1PI1km-0008T2-0A
	for qemu-devel@nongnu.org; Mon, 15 Nov 2010 11:18:04 -0500
Received: from demumfd001.nsn-inter.net ([93.183.12.32]:12279)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bernhard.kohl@nsn.com>) id 1PI1kl-0008ST-Nq
	for qemu-devel@nongnu.org; Mon, 15 Nov 2010 11:17:59 -0500
Message-ID: <4CE15D34.8030507@nsn.com>
Date: Mon, 15 Nov 2010 17:17:56 +0100
From: Bernhard Kohl <bernhard.kohl@nsn.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH] pc: disable the BOCHS BIOS panic port
References: <1283352240-24127-1-git-send-email-bernhard.kohl@nsn.com>
	<4CE102FE.40309@nsn.com>
	<D57FF643-7385-464E-AC79-B9C1829D23E3@suse.de>
In-Reply-To: <D57FF643-7385-464E-AC79-B9C1829D23E3@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: ext Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org

Am 15.11.2010 11:09, schrieb ext Alexander Graf:
> On 15.11.2010, at 10:53, Bernhard Kohl wrote:
>
>    
>> Am 01.09.2010 16:44, schrieb Bernhard Kohl:
>>      
>>> We have an OS which writes to port 0x400 when probing for special hardware.
>>> This causes an exit of the VM. With SeaBIOS this port isn't used anyway.
>>>
>>> Signed-off-by: Bernhard Kohl<bernhard.kohl@nsn.com>
>>> ---
>>>   hw/pc.c |    2 --
>>>   1 files changed, 0 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/hw/pc.c b/hw/pc.c
>>> index 69b13bf..3f81229 100644
>>> --- a/hw/pc.c
>>> +++ b/hw/pc.c
>>> @@ -430,8 +430,6 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val)
>>>           /* Bochs BIOS messages */
>>>       case 0x400:
>>>       case 0x401:
>>> -        fprintf(stderr, "BIOS panic at rombios.c, line %d\n", val);
>>> -        exit(1);
>>>       case 0x402:
>>>       case 0x403:
>>>   #ifdef DEBUG_BIOS
>>>
>>>        
>> Hi,
>>
>> could you please look at this?
>>      
> This patch makes that port that was silent before print debug output if DEBUG_BIOS is enabled which might be confusing.
>
> How about something like
>
> case 0x400:
> case 0x401:
>      /* used to be panic, now unused */
>      break;
>
>
> Alex
>
>
>    
Yes, you are right. I will take your proposal in patch v2.

Bernhard