* [Qemu-devel] [PATCH] pc: disable the BOCHS BIOS panic port
@ 2010-09-01 14:44 Bernhard Kohl
2010-11-15 9:53 ` [Qemu-devel] " Bernhard Kohl
0 siblings, 1 reply; 4+ messages in thread
From: Bernhard Kohl @ 2010-09-01 14:44 UTC (permalink / raw)
To: qemu-devel; +Cc: Bernhard Kohl
We have an OS which writes to port 0x400 when probing for special hardware.
This causes an exit of the VM. With SeaBIOS this port isn't used anyway.
Signed-off-by: Bernhard Kohl <bernhard.kohl@nsn.com>
---
hw/pc.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index 69b13bf..3f81229 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -430,8 +430,6 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val)
/* Bochs BIOS messages */
case 0x400:
case 0x401:
- fprintf(stderr, "BIOS panic at rombios.c, line %d\n", val);
- exit(1);
case 0x402:
case 0x403:
#ifdef DEBUG_BIOS
--
1.7.2.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Qemu-devel] Re: [PATCH] pc: disable the BOCHS BIOS panic port
2010-09-01 14:44 [Qemu-devel] [PATCH] pc: disable the BOCHS BIOS panic port Bernhard Kohl
@ 2010-11-15 9:53 ` Bernhard Kohl
2010-11-15 10:09 ` Alexander Graf
0 siblings, 1 reply; 4+ messages in thread
From: Bernhard Kohl @ 2010-11-15 9:53 UTC (permalink / raw)
To: qemu-devel
Am 01.09.2010 16:44, schrieb Bernhard Kohl:
> We have an OS which writes to port 0x400 when probing for special hardware.
> This causes an exit of the VM. With SeaBIOS this port isn't used anyway.
>
> Signed-off-by: Bernhard Kohl<bernhard.kohl@nsn.com>
> ---
> hw/pc.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pc.c b/hw/pc.c
> index 69b13bf..3f81229 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -430,8 +430,6 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val)
> /* Bochs BIOS messages */
> case 0x400:
> case 0x401:
> - fprintf(stderr, "BIOS panic at rombios.c, line %d\n", val);
> - exit(1);
> case 0x402:
> case 0x403:
> #ifdef DEBUG_BIOS
>
Hi,
could you please look at this?
Thanks
Bernhard
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] Re: [PATCH] pc: disable the BOCHS BIOS panic port
2010-11-15 9:53 ` [Qemu-devel] " Bernhard Kohl
@ 2010-11-15 10:09 ` Alexander Graf
2010-11-15 16:17 ` Bernhard Kohl
0 siblings, 1 reply; 4+ messages in thread
From: Alexander Graf @ 2010-11-15 10:09 UTC (permalink / raw)
To: Bernhard Kohl; +Cc: qemu-devel
On 15.11.2010, at 10:53, Bernhard Kohl wrote:
> Am 01.09.2010 16:44, schrieb Bernhard Kohl:
>> We have an OS which writes to port 0x400 when probing for special hardware.
>> This causes an exit of the VM. With SeaBIOS this port isn't used anyway.
>>
>> Signed-off-by: Bernhard Kohl<bernhard.kohl@nsn.com>
>> ---
>> hw/pc.c | 2 --
>> 1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/pc.c b/hw/pc.c
>> index 69b13bf..3f81229 100644
>> --- a/hw/pc.c
>> +++ b/hw/pc.c
>> @@ -430,8 +430,6 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val)
>> /* Bochs BIOS messages */
>> case 0x400:
>> case 0x401:
>> - fprintf(stderr, "BIOS panic at rombios.c, line %d\n", val);
>> - exit(1);
>> case 0x402:
>> case 0x403:
>> #ifdef DEBUG_BIOS
>>
>
> Hi,
>
> could you please look at this?
This patch makes that port that was silent before print debug output if DEBUG_BIOS is enabled which might be confusing.
How about something like
case 0x400:
case 0x401:
/* used to be panic, now unused */
break;
Alex
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] Re: [PATCH] pc: disable the BOCHS BIOS panic port
2010-11-15 10:09 ` Alexander Graf
@ 2010-11-15 16:17 ` Bernhard Kohl
0 siblings, 0 replies; 4+ messages in thread
From: Bernhard Kohl @ 2010-11-15 16:17 UTC (permalink / raw)
To: ext Alexander Graf; +Cc: qemu-devel
Am 15.11.2010 11:09, schrieb ext Alexander Graf:
> On 15.11.2010, at 10:53, Bernhard Kohl wrote:
>
>
>> Am 01.09.2010 16:44, schrieb Bernhard Kohl:
>>
>>> We have an OS which writes to port 0x400 when probing for special hardware.
>>> This causes an exit of the VM. With SeaBIOS this port isn't used anyway.
>>>
>>> Signed-off-by: Bernhard Kohl<bernhard.kohl@nsn.com>
>>> ---
>>> hw/pc.c | 2 --
>>> 1 files changed, 0 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/hw/pc.c b/hw/pc.c
>>> index 69b13bf..3f81229 100644
>>> --- a/hw/pc.c
>>> +++ b/hw/pc.c
>>> @@ -430,8 +430,6 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val)
>>> /* Bochs BIOS messages */
>>> case 0x400:
>>> case 0x401:
>>> - fprintf(stderr, "BIOS panic at rombios.c, line %d\n", val);
>>> - exit(1);
>>> case 0x402:
>>> case 0x403:
>>> #ifdef DEBUG_BIOS
>>>
>>>
>> Hi,
>>
>> could you please look at this?
>>
> This patch makes that port that was silent before print debug output if DEBUG_BIOS is enabled which might be confusing.
>
> How about something like
>
> case 0x400:
> case 0x401:
> /* used to be panic, now unused */
> break;
>
>
> Alex
>
>
>
Yes, you are right. I will take your proposal in patch v2.
Bernhard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-11-15 16:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-01 14:44 [Qemu-devel] [PATCH] pc: disable the BOCHS BIOS panic port Bernhard Kohl
2010-11-15 9:53 ` [Qemu-devel] " Bernhard Kohl
2010-11-15 10:09 ` Alexander Graf
2010-11-15 16:17 ` Bernhard Kohl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).