From: Stefan Weil <weil@mail.berlios.de>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: Blue Swirl <blauwirbel@gmail.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] *-dis: Replace fprintf_ftype by fprintf_function (format checking)
Date: Mon, 15 Nov 2010 21:12:26 +0100 [thread overview]
Message-ID: <4CE1942A.4060405@mail.berlios.de> (raw)
In-Reply-To: <3600835A-8E76-4490-BBEA-CE5DC23BD87D@web.de>
Am 15.11.2010 21:01, schrieb Andreas Färber:
> Am 15.11.2010 um 19:39 schrieb Stefan Weil:
>
>> This patch adds more printf format checking.
>>
>> Additional modifications were needed for this code change:
>>
>> * alpha-dis.c: The local definition of MAX conflicts with
>> a previous definition from osdep.h, so add an #undef.
>>
>> * dis-asm.h: Add include for fprintf_function (qemu-common.h).
>> The standard (now redundant) includes are removed.
>>
>> * mis-dis.c:
>
> :-)
Thanks. Hopefully nobody will mis-interpret the missing 'p' :-)
Maybe Blue Swirl can add it, or simply commit it as it is
(so future readers of the commit log have fun, too).
next prev parent reply other threads:[~2010-11-15 21:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 18:39 [Qemu-devel] [PATCH] *-dis: Replace fprintf_ftype by fprintf_function (format checking) Stefan Weil
2010-11-15 20:01 ` Andreas Färber
2010-11-15 20:12 ` Stefan Weil [this message]
2010-12-04 20:54 ` [Qemu-devel] " Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE1942A.4060405@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=andreas.faerber@web.de \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).