From: Anthony Liguori <anthony@codemonkey.ws>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Juan Quintela <quintela@redhat.com>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device
Date: Mon, 15 Nov 2010 15:05:39 -0600 [thread overview]
Message-ID: <4CE1A0A3.4050406@codemonkey.ws> (raw)
In-Reply-To: <AANLkTikaYDJ=NNWF0e9bp4B6GDrY20gitdvvJD632Epi@mail.gmail.com>
On 11/15/2010 02:53 PM, Stefan Hajnoczi wrote:
>
> vhost has a solution for this: register a VMChangeStateHandler
> function that stops ioeventfd while vm_stop(0) is in effect. Then
> poll to see if there is work pending.
>
> I will add equivalent functionality to virtio-ioeventfd.
>
I still think that stopping this at the net/block layer is going to be a
lot more robust in the long term. All net/block traffic flows through a
single set of interfaces whereas getting the devices to completely stop
themselves requires touching every device and making sure that noone
adds back vmstop-unfriendly behavior down the road.
Regards,
Anthony Liguori
> Stefan
>
next prev parent reply other threads:[~2010-11-15 21:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-04 18:04 [Qemu-devel] [PATCHv2 0/2] migration: stop dma while VM is stopped Michael S. Tsirkin
2010-11-04 18:06 ` [Qemu-devel] [PATCHv2 1/2] char: separate device and system fd handlers Michael S. Tsirkin
2010-11-16 10:24 ` [Qemu-devel] " Juan Quintela
2010-11-04 18:06 ` [Qemu-devel] [PATCHv2 2/2] tap: mark fd handler as device Michael S. Tsirkin
2010-11-15 14:52 ` [Qemu-devel] " Juan Quintela
2010-11-15 14:55 ` Anthony Liguori
2010-11-15 15:18 ` Michael S. Tsirkin
2010-11-15 16:09 ` Anthony Liguori
2010-11-15 20:26 ` Michael S. Tsirkin
2010-11-15 20:37 ` Anthony Liguori
2010-11-15 20:53 ` Stefan Hajnoczi
2010-11-15 21:05 ` Anthony Liguori [this message]
2010-11-15 22:44 ` Michael S. Tsirkin
2010-11-15 23:46 ` Anthony Liguori
2010-11-15 15:21 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE1A0A3.4050406@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).