qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	Gleb Natapov <gleb@redhat.com>,
	Stefan Hajnoczi <stefanha@gmail.com>,
	Michael Tokarev <mjt@tls.msk.ru>,
	qemu-devel <qemu-devel@nongnu.org>,
	Kevin O'Connor <kevin@koconnor.net>
Subject: Re: [Qemu-devel] virtio-blk broken after system reset
Date: Mon, 15 Nov 2010 15:16:32 -0600	[thread overview]
Message-ID: <4CE1A330.7030502@codemonkey.ws> (raw)
In-Reply-To: <4CDE63CD.8050505@web.de>

On 11/13/2010 04:09 AM, Jan Kiszka wrote:
>
> There is also real hw out there that goes into an error state if it's
> misprogrammed.
>
> I think we have to remove all those premature exits. They also prevent
> handing the device inside the guest to an untrusted driver (relevant
> once we have IOMMU emulation).
>    

I think the key to achieving this is to isolate the device within QEMU.

IOW, have all fd callbacks, bottom halves, etc. tagged with a device 
context.  Have a mechanism that raises an error on a device that can 
then be used to stop issuing any type of callback to the device until reset.

Obviously, we can fix some of these by just simple code refactoring.

Regards,

Anthony Liguori

>> Why it is trying to print things to stderr is a different
>> matter, it should be using a proper error-reporting routine,
>> but this is a different story.
>>      
> Jep. Even worse: the above message is not dumped to the console as the
> stream isn't flushed on exit.
>
> Jan
>
>    

      parent reply	other threads:[~2010-11-15 21:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-12 22:02 [Qemu-devel] virtio-blk broken after system reset Jan Kiszka
2010-11-13  7:49 ` Stefan Hajnoczi
2010-11-13  7:51   ` Jan Kiszka
2010-11-13 10:01     ` Michael Tokarev
2010-11-13 10:09       ` Jan Kiszka
2010-11-13 10:54         ` Stefan Hajnoczi
2010-11-13 11:08           ` Jan Kiszka
2010-11-15 10:42         ` Kevin Wolf
2010-11-15 21:16         ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CE1A330.7030502@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=gleb@redhat.com \
    --cc=jan.kiszka@web.de \
    --cc=kevin@koconnor.net \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).