From: Anthony Liguori <anthony@codemonkey.ws>
To: John Morrissey <jwm@horde.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RESEND][PATCH] Remove 16-character limit on process title
Date: Tue, 16 Nov 2010 09:34:43 -0600 [thread overview]
Message-ID: <4CE2A493.8050708@codemonkey.ws> (raw)
In-Reply-To: <20101105163549.GA12049@boost.horde.net>
On 11/05/2010 11:35 AM, John Morrissey wrote:
> qemu uses prctl() to set its process title. I bumped up against prctl()'s
> 16-character limit recently, when adding process title support to
> libvirt[1][2].
>
> The attached patch overwrites argv instead. Linux seems to maintain the
> length of the original args, even when the new args are shorter and
> NULL-terminated, so the trailing whitespace in ps(1) output is probably
> unavoidable. I've seen the same result with other daemons that overwrite
> argv.
>
> john
>
> [1] https://www.redhat.com/archives/libvir-list/2010-October/msg00565.html
> [2] http://libvirt.org/git/?p=libvirt.git;a=commit;h=c08c7b0143b8cdc542e5f4137623d412340c5cf2
>
Needs a Signed-off-by.
Regards,
Anthony Liguori
prev parent reply other threads:[~2010-11-16 15:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 19:10 [Qemu-devel] [PATCH] Remove 16-character limit on process title John Morrissey
2010-11-05 16:35 ` [Qemu-devel] [RESEND][PATCH] " John Morrissey
2010-11-07 14:24 ` Andreas Färber
2010-11-16 15:34 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE2A493.8050708@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=jwm@horde.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).