From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=41770 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PIOcI-0000u0-Ao
	for qemu-devel@nongnu.org; Tue, 16 Nov 2010 11:42:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PIOcH-0006dY-C8
	for qemu-devel@nongnu.org; Tue, 16 Nov 2010 11:42:46 -0500
Received: from mail-pv0-f173.google.com ([74.125.83.173]:38971)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PIOcH-0006dQ-6B
	for qemu-devel@nongnu.org; Tue, 16 Nov 2010 11:42:45 -0500
Received: by pvh11 with SMTP id 11so205008pvh.4
	for <qemu-devel@nongnu.org>; Tue, 16 Nov 2010 08:42:44 -0800 (PST)
Message-ID: <4CE2B435.4060003@codemonkey.ws>
Date: Tue, 16 Nov 2010 10:41:25 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Introduce -accel command option.
References: <1289835951-25567-1-git-send-email-anthony.perard@citrix.com>
	<4CE165E0.5040705@codemonkey.ws>
	<alpine.DEB.1.10.1011161545090.7001@perard.cam.xci-test.com>
In-Reply-To: <alpine.DEB.1.10.1011161545090.7001@perard.cam.xci-test.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: QEMU-devel <qemu-devel@nongnu.org>

On 11/16/2010 10:10 AM, Anthony PERARD wrote:
> On Mon, 15 Nov 2010, Anthony Liguori wrote:
>
>    
>> On 11/15/2010 09:45 AM, anthony.perard@citrix.com wrote:
>>      
>>> From: Anthony PERARD<anthony.perard@citrix.com>
>>>
>>> This option gives the ability to switch one "accelerator" like kvm, xen
>>> or the default one tcg. We can specify more than one accelerator by
>>> separate them by a comma. QEMU will try each one and use the first whose
>>> works.
>>>
>>> So,
>>>
>>> -accel xen,kvm,tcg
>>>
>>> which would try Xen support first, then KVM and finaly tcg if none of
>>> the other works.
>>>
>>>        
>> Should use QemuOpts instead of parsing by hand.
>>      
> Ok for that.
>
>    
>> I'd rather it be
>> presented as a -machine option too with accel=xen:kvm:tcg to specify order.
>>      
> This is not clear to me, did you mean that you prefer to have both
> "-accel accels" and "-machine accel=accels" options?
>    

Just -machine accel=accels.

Part of my rational is that accelerator is a machine property.  If you 
do -M xenpv it ought to imply -machine accel=xen.

Regards,

Anthony Liguori

> For the -machine options, I can put it in qemu-config.c and it will be
> saved.
>
> Regards,
>
>