From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41348 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PIe0O-0005DE-3K for qemu-devel@nongnu.org; Wed, 17 Nov 2010 04:08:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PIe0N-0000vZ-4d for qemu-devel@nongnu.org; Wed, 17 Nov 2010 04:08:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32497) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PIe0M-0000vT-Te for qemu-devel@nongnu.org; Wed, 17 Nov 2010 04:08:39 -0500 Message-ID: <4CE39B73.5000302@redhat.com> Date: Wed, 17 Nov 2010 10:08:03 +0100 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 08/10] ahci: add ahci emulation References: <1289955937-24121-1-git-send-email-agraf@suse.de> <1289955937-24121-9-git-send-email-agraf@suse.de> In-Reply-To: <1289955937-24121-9-git-send-email-agraf@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: tj@kernel.org, Joerg Roedel , Roland Elek , QEMU-devel Developers , Sebastian Herbszt Hi, > +static AHCIState *ahci_new(void) > +{ > + int i; > + > +static int pci_ahci_init(PCIDevice *dev) > +{ > + d->ahci = ahci_new(); > + d->ahci->irq = d->card.irq[0]; > + return 0; > +} Hmm, no bus registered anywhere. Dunno whenever it makes sense to register ide bus(es) here or whenever we should create a new sata bus. cheers, Gerd