From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=43194 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PIeX8-0006Mr-2R for qemu-devel@nongnu.org; Wed, 17 Nov 2010 04:42:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PIeX7-0006V7-0k for qemu-devel@nongnu.org; Wed, 17 Nov 2010 04:42:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:14455) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PIeX6-0006V0-QJ for qemu-devel@nongnu.org; Wed, 17 Nov 2010 04:42:28 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oAH9gP1t018766 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 17 Nov 2010 04:42:25 -0500 Message-ID: <4CE3A37E.1010302@redhat.com> Date: Wed, 17 Nov 2010 11:42:22 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v3 2/4] switch stdvga to pci vgabios References: <1288785372-17514-1-git-send-email-kraxel@redhat.com> <1288785372-17514-3-git-send-email-kraxel@redhat.com> In-Reply-To: <1288785372-17514-3-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On 11/03/2010 01:56 PM, Gerd Hoffmann wrote: > Make stdvga provide the new vgabios binary (with pcibios support) > using the PCI option rom bar. Seabios will happily load it from > there. The new vga bios will also lookup the framebuffer address > in pci config space, so the magic bochs lfb @ 0xe0000000 is not > needed any more -> zap it. > > Without the patch: > > # dmesg | grep framebuffer > vesafb: framebuffer at 0xe0000000, mapped to 0xf7e80000, using 1875k, total 8192k > # lspci -vs2 > 00:02.0 VGA compatible controller: Technical Corp. Device 1111 (prog-if 00 [VGA controller]) > Subsystem: Qumranet, Inc. Device 1100 > Physical Slot: 2 > Flags: fast devsel > Memory at f0000000 (32-bit, prefetchable) [size=8M] > Expansion ROM at [disabled] > > With patch applied: > > # dmesg | grep framebuffer > vesafb: framebuffer at 0xf0000000, mapped to 0xf7e80000, using 1875k, total 8192k > # lspci -vs2 > 00:02.0 VGA compatible controller: Technical Corp. Device 1111 (prog-if 00 [VGA controller]) > Subsystem: Qumranet, Inc. Device 1100 > Physical Slot: 2 > Flags: fast devsel > Memory at f0000000 (32-bit, prefetchable) [size=8M] > Expansion ROM at f0800000 [disabled] [size=64K] > This is a guest visible change... does it need -M 0.13 support? Will live migration from 0.13 to 0.14 work? -- error compiling committee.c: too many arguments to function