From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=47821 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PJ2vX-0007l8-34
	for qemu-devel@nongnu.org; Thu, 18 Nov 2010 06:45:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PJ2vV-0001gS-M8
	for qemu-devel@nongnu.org; Thu, 18 Nov 2010 06:45:18 -0500
Received: from mx1.redhat.com ([209.132.183.28]:5553)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PJ2vV-0001gG-DK
	for qemu-devel@nongnu.org; Thu, 18 Nov 2010 06:45:17 -0500
Message-ID: <4CE511C4.1060807@redhat.com>
Date: Thu, 18 Nov 2010 12:45:08 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC][PATCH v3 17/21] virtproxy:
	add	virtproxy-builtin.c for compat defs
References: <1289870175-14880-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1289870175-14880-18-git-send-email-mdroth@linux.vnet.ibm.com>
In-Reply-To: <1289870175-14880-18-git-send-email-mdroth@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: agl@linux.vnet.ibm.com, abeekhof@redhat.com, qemu-devel@nongnu.org, aliguori@linux.vnet.ibm.com, ryanh@us.ibm.com, amit.shah@redhat.com

On 11/16/10 02:16, Michael Roth wrote:
> Virtproxy relies on routines defined within qemu-vp which mirror various
> i/o related operations in qemu to provide similar functionality for the
> guest daemon. When building virtproxy as part of qemu rather than
> qemu-vp we need these definitions to provide those functions in terms of
> the original qemu functions.
> 
> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> ---
>  virtproxy-builtin.c |   38 ++++++++++++++++++++++++++++++++++++++
>  1 files changed, 38 insertions(+), 0 deletions(-)
>  create mode 100644 virtproxy-builtin.c
> 
> diff --git a/virtproxy-builtin.c b/virtproxy-builtin.c
> new file mode 100644
> index 0000000..71fc5bc
> --- /dev/null
> +++ b/virtproxy-builtin.c
> @@ -0,0 +1,38 @@
> +/*
> + * virt-proxy - host/guest communication layer builtin definitions
> + *
> + * Copyright IBM Corp. 2010
> + *
> + * Authors:
> + *  Adam Litke        <aglitke@linux.vnet.ibm.com>
> + *  Michael Roth      <mdroth@linux.vnet.ibm.com>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or later.
> + * See the COPYING file in the top-level directory.
> + *
> + */
> +
> +/* the following are functions we define in terms of qemu when linked
> + * against qemu/vl.c. these will be added on an as-needed basis
> + */
> +
> +#include "qemu-char.h"
> +#include "qemu_socket.h"
> +#include "virtproxy.h"
> +
> +int vp_set_fd_handler(int fd,
> +                        IOHandler *fd_read,
> +                        IOHandler *fd_write,
> +                        void *opaque)

odd alignment again.

Jes