From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=47665 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJ5Fa-0006vL-2U for qemu-devel@nongnu.org; Thu, 18 Nov 2010 09:14:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PJ5FZ-0003fa-46 for qemu-devel@nongnu.org; Thu, 18 Nov 2010 09:14:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35281) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PJ5FY-0003fU-SH for qemu-devel@nongnu.org; Thu, 18 Nov 2010 09:14:09 -0500 Message-ID: <4CE534A4.6060306@redhat.com> Date: Thu, 18 Nov 2010 15:13:56 +0100 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RFC][PATCH v4 06/18] virtagent: add agent_viewfile command References: <1289923320-5638-1-git-send-email-mdroth@linux.vnet.ibm.com> <1289923320-5638-7-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1289923320-5638-7-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: aliguori@linux.vnet.ibm.com, ryanh@us.ibm.com, agl@linux.vnet.ibm.com, qemu-devel@nongnu.org, abeekhof@redhat.com On 11/16/10 17:01, Michael Roth wrote: > Utilize the getfile RPC to provide a means to view text files in the > guest. Getfile can handle binary files as well but we don't advertise > that here due to the special handling requiring to store it and provide > it back to the user (base64 encoding it for instance). Hence the > potentially confusing "viewfile" as opposed to "getfile". > > Signed-off-by: Michael Roth > This one is full of -1 returns again :( Cheers, Jes