From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55495 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PJ5O4-0002cH-96
	for qemu-devel@nongnu.org; Thu, 18 Nov 2010 09:22:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PJ5O3-000589-7F
	for qemu-devel@nongnu.org; Thu, 18 Nov 2010 09:22:56 -0500
Received: from mx1.redhat.com ([209.132.183.28]:29267)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PJ5O2-00057u-W4
	for qemu-devel@nongnu.org; Thu, 18 Nov 2010 09:22:55 -0500
Message-ID: <4CE536B6.7000006@redhat.com>
Date: Thu, 18 Nov 2010 15:22:46 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC][PATCH v4 17/18] virtagent: qemu-vp,
	va_send_hello() on startup
References: <1289923320-5638-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1289923320-5638-18-git-send-email-mdroth@linux.vnet.ibm.com>
In-Reply-To: <1289923320-5638-18-git-send-email-mdroth@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: aliguori@linux.vnet.ibm.com, ryanh@us.ibm.com, agl@linux.vnet.ibm.com, qemu-devel@nongnu.org, abeekhof@redhat.com

On 11/16/10 17:01, Michael Roth wrote:
> Make the hello call on guest agent startup so QEMU can do whatever init
> it needs (currently, capabilities negotiation). Temporarilly commented
> due to this tending to induce a virtio bug in RHEL 6.0. As a result
> capabilities negotiation must be invoked manually from QEMU via the
> agent_capabilities monitor command.
> 
> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> ---
>  qemu-vp.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/qemu-vp.c b/qemu-vp.c
> index 38959e5..b8af513 100644
> --- a/qemu-vp.c
> +++ b/qemu-vp.c
> @@ -580,6 +580,8 @@ int main(int argc, char **argv)
>              errx(EXIT_FAILURE,
>                   "error initializing guest agent");
>          }
> +        /* tell the host the agent is running */
> +        //va_send_hello();

Ehm, not much point adding a call that is commented out :)

Cheers,
Jes