From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=38815 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJ7AY-0000Tg-5v for qemu-devel@nongnu.org; Thu, 18 Nov 2010 11:17:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PJ7AW-00048Q-UR for qemu-devel@nongnu.org; Thu, 18 Nov 2010 11:17:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:22594) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PJ7AW-00048I-MI for qemu-devel@nongnu.org; Thu, 18 Nov 2010 11:17:04 -0500 Message-ID: <4CE55177.1020602@redhat.com> Date: Thu, 18 Nov 2010 17:16:55 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <20101118144728.9581CF90AB@ochil.suse.de> In-Reply-To: <20101118144728.9581CF90AB@ochil.suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 10/16] scsi: Use 'SCSIRequest' directly List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hannes Reinecke Cc: stefanha@gmail.com, qemu-devel@nongnu.org, nab@linux-iscsi.org On 11/18/10 15:47, Hannes Reinecke wrote: > > Rather than to access a SCSIRequest via an abstract 'tag' we can > as well use it directly and save us the lookup. Hmm. Looks like a few more request handling changes than a pure s/tag/req/ + zap lookups sneaked into that patch. There are new get_req and put_req callbacks for example. At minimum these changes must be documented in the commit message. Even better splitted into separate patches. cheers, Gerd