From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=55334 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJ7OG-0005zi-IR for qemu-devel@nongnu.org; Thu, 18 Nov 2010 11:31:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PJ7OF-000710-Ck for qemu-devel@nongnu.org; Thu, 18 Nov 2010 11:31:16 -0500 Received: from cantor.suse.de ([195.135.220.2]:53160 helo=mx1.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PJ7OF-00070i-2b for qemu-devel@nongnu.org; Thu, 18 Nov 2010 11:31:15 -0500 Message-ID: <4CE55562.7000600@suse.de> Date: Thu, 18 Nov 2010 17:33:38 +0100 From: Hannes Reinecke MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 10/16] scsi: Use 'SCSIRequest' directly References: <20101118144728.9581CF90AB@ochil.suse.de> <4CE55177.1020602@redhat.com> In-Reply-To: <4CE55177.1020602@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: stefanha@gmail.com, qemu-devel@nongnu.org, nab@linux-iscsi.org On 11/18/2010 05:16 PM, Gerd Hoffmann wrote: > On 11/18/10 15:47, Hannes Reinecke wrote: >> >> Rather than to access a SCSIRequest via an abstract 'tag' we can >> as well use it directly and save us the lookup. >=20 > Hmm. Looks like a few more request handling changes than a pure > s/tag/req/ + zap lookups sneaked into that patch. There are new get_re= q > and put_req callbacks for example. At minimum these changes must be > documented in the commit message. Even better splitted into separate > patches. >=20 Not sure if it makes sense to split it up into several patches; we need the ->get_req()/->put_req() callbacks to get the request in the first place. And only then can we modify the other callbacks. However, splitting them off into two patchsets would render the first pretty much pointless. But sure, I can do a better description. Just tell me which direction you prefer. Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: Markus Rex, HRB 16746 (AG N=FCrnberg)