From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=48179 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJLvf-0004vh-PO for qemu-devel@nongnu.org; Fri, 19 Nov 2010 03:02:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PJLve-0007kp-Hd for qemu-devel@nongnu.org; Fri, 19 Nov 2010 03:02:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55218) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PJLve-0007kd-6K for qemu-devel@nongnu.org; Fri, 19 Nov 2010 03:02:42 -0500 Message-ID: <4CE62F14.3090302@redhat.com> Date: Fri, 19 Nov 2010 09:02:28 +0100 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 10/16] scsi: Use 'SCSIRequest' directly References: <20101118144728.9581CF90AB@ochil.suse.de> <4CE55177.1020602@redhat.com> <4CE55562.7000600@suse.de> In-Reply-To: <4CE55562.7000600@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hannes Reinecke Cc: stefanha@gmail.com, qemu-devel@nongnu.org, nab@linux-iscsi.org On 11/18/10 17:33, Hannes Reinecke wrote: > Not sure if it makes sense to split it up into several patches; > we need the ->get_req()/->put_req() callbacks to get the request in > the first place. Point. > And only then can we modify the other callbacks. > However, splitting them off into two patchsets would render the > first pretty much pointless. > > But sure, I can do a better description. Yes, please. thanks, Gerd