From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46515 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PJN1f-00076J-TC
	for qemu-devel@nongnu.org; Fri, 19 Nov 2010 04:13:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PJN1e-0004uy-Ro
	for qemu-devel@nongnu.org; Fri, 19 Nov 2010 04:12:59 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52700)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PJN1e-0004ug-HG
	for qemu-devel@nongnu.org; Fri, 19 Nov 2010 04:12:58 -0500
Message-ID: <4CE63F8B.8020802@redhat.com>
Date: Fri, 19 Nov 2010 10:12:43 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1290050875-23848-1-git-send-email-agraf@suse.de>
	<1290050875-23848-9-git-send-email-agraf@suse.de>
	<4CE4DD74.3070801@redhat.com> <4CE56AED.8070906@suse.de>
In-Reply-To: <4CE56AED.8070906@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 08/10] ahci: add ahci emulation
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Joerg Roedel <Joerg.Roedel@amd.com>, QEMU-devel Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@gmail.com>, tj@kernel.org, Roland Elek <elek.roland@gmail.com>, Sebastian Herbszt <herbszt@gmx.de>

>>> +static void ahci_check_irq(AHCIState *s)
>>
>> MSI support would be nice to have.
>
> Alrighty, I added MSI support. But I only have a single vector in use
> atm as nvec>  0 doesn't get written to the PCI config space so the code
> trips on that later on.

For multiple vectors MSI-X is the best choice as it fixes a few design 
issues MSI has when it comes to multiple vectors.  I think linux never 
ever uses MSI with multiple vectors anyway.

cheers,
   Gerd