From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=32889 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PJRzz-0001Yo-OF
	for qemu-devel@nongnu.org; Fri, 19 Nov 2010 09:31:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PJRzy-0006sZ-KV
	for qemu-devel@nongnu.org; Fri, 19 Nov 2010 09:31:35 -0500
Received: from mx1.redhat.com ([209.132.183.28]:42197)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PJRzy-0006sJ-Dl
	for qemu-devel@nongnu.org; Fri, 19 Nov 2010 09:31:34 -0500
Message-ID: <4CE68A40.5020700@redhat.com>
Date: Fri, 19 Nov 2010 15:31:28 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 16/16] megasas: LSI Megaraid SAS emulation
References: <20101118144755.442B2F90AB@ochil.suse.de>	<4CE64151.7050601@redhat.com>
	<m3lj4pl86o.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3lj4pl86o.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: stefanha@gmail.com, kraxel@redhat.com, Hannes Reinecke <hare@suse.de>, nab@linux-iscsi.org, qemu-devel@nongnu.org

On 11/19/10 15:06, Markus Armbruster wrote:
>> Only comment, as you are adding another SCSI driver, maybe it's time to
>> make the driver selection configurable, rather than hard coding the build?
> 
> What do you mean by that?
> 
> We hardcode lsi53c895a in two places where we really mean "default SCSI
> controller type": pc_pci_device_init(), which applies to "-drive
> if=scsi", and qemu_pci_hot_add_storage(), which applies to "pci_add
> storage if=scsi".  Not sure making that default configurable is worth
> it.
> 
> If you want more control than -drive and pci_add provice, use -device
> and device_add.

What I mean is for most other device types we allow to specify a list of
wanted devices at the configure line, which is what I am suggesting we
added support for for SCSI as well.

Cheers,
Jes