From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=50750 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PK94x-0002K2-4A for qemu-devel@nongnu.org; Sun, 21 Nov 2010 07:31:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PK94p-0005x3-9p for qemu-devel@nongnu.org; Sun, 21 Nov 2010 07:31:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49282) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PK94p-0005wq-28 for qemu-devel@nongnu.org; Sun, 21 Nov 2010 07:31:27 -0500 Message-ID: <4CE9111C.3010708@redhat.com> Date: Sun, 21 Nov 2010 13:31:24 +0100 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects References: <1290184248-30078-1-git-send-email-Jes.Sorensen@redhat.com> <7BADF5D6-2BE4-4F2B-A241-24D6BD45DD8E@web.de> In-Reply-To: <7BADF5D6-2BE4-4F2B-A241-24D6BD45DD8E@web.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: QEMU Developers , Juan Quintela On 11/20/10 18:22, Andreas F=E4rber wrote: > Am 19.11.2010 um 17:30 schrieb Jes.Sorensen@redhat.com: >=20 >> From: Jes Sorensen >> >> Signed-off-by: Jes Sorensen >> --- >> Makefile | 2 +- >> Makefile.objs | 12 ++++++++++-- >> 2 files changed, 11 insertions(+), 3 deletions(-) >=20 > Tested-by: Andreas F=E4rber >=20 > Looks good to me and a clean build works okay. >=20 > Any plans for a way to disable NBD build completely? There are warnings > about use of daemon() on Mac OS X and possibly Solaris, and there's > little point in building qemu-nbd if one does not use it. I think it would be worth adding as an option, however letting it default to 'on' to make sure it gets at least build tested unless a user explicitly disables it. Cheers, Jes