From: Anthony Liguori <anthony@codemonkey.ws>
To: Bernhard Kohl <bernhard.kohl@nsn.com>
Cc: qemu-devel@nongnu.org, agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH v2] pc: disable the BOCHS BIOS panic port
Date: Sun, 21 Nov 2010 09:20:07 -0600 [thread overview]
Message-ID: <4CE938A7.2040303@codemonkey.ws> (raw)
In-Reply-To: <1289910517-4576-1-git-send-email-bernhard.kohl@nsn.com>
On 11/16/2010 06:28 AM, Bernhard Kohl wrote:
> We have an OS which writes to port 0x400 when probing for special hardware.
> This causes an exit of the VM. With SeaBIOS this port isn't used anyway.
>
> Signed-off-by: Bernhard Kohl<bernhard.kohl@nsn.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> Changes v1 -> v2:
> Keep the ports silent. Don't print debug output if DEBUG_BIOS is enabled
> which might be confusing.
> ---
> hw/pc.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pc.c b/hw/pc.c
> index 3bf3862..76eabe8 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -434,8 +434,8 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val)
> /* Bochs BIOS messages */
> case 0x400:
> case 0x401:
> - fprintf(stderr, "BIOS panic at rombios.c, line %d\n", val);
> - exit(1);
> + /* used to be panic, now unused */
> + break;
> case 0x402:
> case 0x403:
> #ifdef DEBUG_BIOS
>
prev parent reply other threads:[~2010-11-21 15:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 12:28 [Qemu-devel] [PATCH v2] pc: disable the BOCHS BIOS panic port Bernhard Kohl
2010-11-16 13:16 ` [Qemu-devel] " Alexander Graf
2010-11-16 13:49 ` Paolo Bonzini
2010-11-21 15:20 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE938A7.2040303@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=agraf@suse.de \
--cc=bernhard.kohl@nsn.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).