From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49478 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PKBip-00064K-Gi for qemu-devel@nongnu.org; Sun, 21 Nov 2010 10:20:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PKBio-0004it-C9 for qemu-devel@nongnu.org; Sun, 21 Nov 2010 10:20:55 -0500 Received: from mail-yx0-f173.google.com ([209.85.213.173]:62626) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PKBio-0004ip-8U for qemu-devel@nongnu.org; Sun, 21 Nov 2010 10:20:54 -0500 Received: by yxs7 with SMTP id 7so769865yxs.4 for ; Sun, 21 Nov 2010 07:20:54 -0800 (PST) Message-ID: <4CE938D3.4030300@codemonkey.ws> Date: Sun, 21 Nov 2010 09:20:51 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/4] virtio: Convert fprintf() to error_report() References: <1289853878-15188-1-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1289853878-15188-1-git-send-email-stefanha@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org On 11/15/2010 02:44 PM, Stefan Hajnoczi wrote: > The virtio hardware emulation code uses fprintf(stderr, ...) error messages. > Improve things slightly by moving to error_report() so error messages will be > printed to the monitor, if present. > > We want to handle device error states properly instead of bailing out with > exit(1) but this series does not attempt to fix that yet. > > Leave virtio-9p for now where there are many cases of fprintf(stderr, ...) and > development is still very active. > Applied all. Thanks. Regards, Anthony Liguori > >