From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=50133 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PKBkw-0007aC-Ai
	for qemu-devel@nongnu.org; Sun, 21 Nov 2010 10:23:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PKBkv-0004xp-6A
	for qemu-devel@nongnu.org; Sun, 21 Nov 2010 10:23:06 -0500
Received: from mail-yx0-f173.google.com ([209.85.213.173]:44317)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PKBkv-0004xa-3I
	for qemu-devel@nongnu.org; Sun, 21 Nov 2010 10:23:05 -0500
Received: by yxs7 with SMTP id 7so770488yxs.4
	for <qemu-devel@nongnu.org>; Sun, 21 Nov 2010 07:23:04 -0800 (PST)
Message-ID: <4CE93956.8040208@codemonkey.ws>
Date: Sun, 21 Nov 2010 09:23:02 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Makefile: Fix check dependency breakage
References: <20101112125546.6d2202b4@doriath>
In-Reply-To: <20101112125546.6d2202b4@doriath>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

On 11/12/2010 08:55 AM, Luiz Capitulino wrote:
> Commit b152aa84d52882bb1846485a89baf13aa07c86bc broke the unit-tests
> build, fix it.
>
> Signed-off-by: Luiz Capitulino<lcapitulino@redhat.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   Makefile |   14 ++++++++------
>   1 files changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 02698e9..719aca9 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -142,12 +142,14 @@ qemu-img-cmds.h: $(SRC_PATH)/qemu-img-cmds.hx
>
>   check-qint.o check-qstring.o check-qdict.o check-qlist.o check-qfloat.o check-qjson.o: $(GENERATED_HEADERS)
>
> -check-qint: check-qint.o qint.o qemu-malloc.o $(trace-obj-y)
> -check-qstring: check-qstring.o qstring.o qemu-malloc.o $(trace-obj-y)
> -check-qdict: check-qdict.o qdict.o qfloat.o qint.o qstring.o qbool.o qemu-malloc.o qlist.o $(trace-obj-y)
> -check-qlist: check-qlist.o qlist.o qint.o qemu-malloc.o $(trace-obj-y)
> -check-qfloat: check-qfloat.o qfloat.o qemu-malloc.o $(trace-obj-y)
> -check-qjson: check-qjson.o qfloat.o qint.o qdict.o qstring.o qlist.o qbool.o qjson.o json-streamer.o json-lexer.o json-parser.o qemu-malloc.o $(trace-obj-y)
> +CHECK_PROG_DEPS = qemu-malloc.o $(oslib-obj-y) $(trace-obj-y)
> +
> +check-qint: check-qint.o qint.o $(CHECK_PROG_DEPS)
> +check-qstring: check-qstring.o qstring.o $(CHECK_PROG_DEPS)
> +check-qdict: check-qdict.o qdict.o qfloat.o qint.o qstring.o qbool.o qlist.o $(CHECK_PROG_DEPS)
> +check-qlist: check-qlist.o qlist.o qint.o $(CHECK_PROG_DEPS)
> +check-qfloat: check-qfloat.o qfloat.o $(CHECK_PROG_DEPS)
> +check-qjson: check-qjson.o qfloat.o qint.o qdict.o qstring.o qlist.o qbool.o qjson.o json-streamer.o json-lexer.o json-parser.o $(CHECK_PROG_DEPS)
>
>   clean:
>   # avoid old build problems by removing potentially incorrect old files
>