From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=53454 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PKPvJ-0002oL-0F
	for qemu-devel@nongnu.org; Mon, 22 Nov 2010 01:30:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PKPvG-0001Jo-IF
	for qemu-devel@nongnu.org; Mon, 22 Nov 2010 01:30:43 -0500
Received: from mx1.redhat.com ([209.132.183.28]:14228)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PKPvG-0001Jk-7X
	for qemu-devel@nongnu.org; Mon, 22 Nov 2010 01:30:42 -0500
Message-ID: <4CEA0D79.4070500@redhat.com>
Date: Mon, 22 Nov 2010 07:28:09 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v3] virtio-9p: fix build on !CONFIG_UTIMENSAT
References: <BC00F5384FCFC9499AF06F92E8B78A9E1AC3EFA17E@shsmsx502.ccr.corp.intel.com>	<4CB56715.7080605@jp.fujitsu.com>	<AANLkTin2nTQ2W=URcpjkrjGtHMzYfdftacwKxb+qdoSx@mail.gmail.com>	<4CB64FF6.5080906@jp.fujitsu.com>	<20101104170303.GE15211@sequoia.sous-sol.org>	<4CD3A513.2010102@jp.fujitsu.com>	<20101114055822.GE25164@sequoia.sous-sol.org>	<4CE0969D.5070703@jp.fujitsu.com>
	<4CE097C4.3070700@jp.fujitsu.com> <4CE93923.4050303@codemonkey.ws>
In-Reply-To: <4CE93923.4050303@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Chris Wright <chrisw@sous-sol.org>, Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "Hao,
	Xudong" <xudong.hao@intel.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>, mohan@in.ibm.com, Avi Kivity <avi@redhat.com>

On 11/21/10 16:22, Anthony Liguori wrote:
> On 11/14/2010 08:15 PM, Hidetoshi Seto wrote:
>> This patch introduce a fallback mechanism for old systems that do not
>> support utimensat().  This fix build failure with following warnings:
>>
>> hw/virtio-9p-local.c: In function 'local_utimensat':
>> hw/virtio-9p-local.c:479: warning: implicit declaration of function
>> 'utimensat'
>> hw/virtio-9p-local.c:479: warning: nested extern declaration of
>> 'utimensat'
>>
>> and:
>>
>> hw/virtio-9p.c: In function 'v9fs_setattr_post_chmod':
>> hw/virtio-9p.c:1410: error: 'UTIME_NOW' undeclared (first use in this
>> function)
>> hw/virtio-9p.c:1410: error: (Each undeclared identifier is reported
>> only once
>> hw/virtio-9p.c:1410: error: for each function it appears in.)
>> hw/virtio-9p.c:1413: error: 'UTIME_OMIT' undeclared (first use in this
>> function)
>> hw/virtio-9p.c: In function 'v9fs_wstat_post_chmod':
>> hw/virtio-9p.c:2905: error: 'UTIME_OMIT' undeclared (first use in this
>> function)
>>
>> v3:
>>    - Use better alternative handling for UTIME_NOW/OMIT
>>    - Move qemu_utimensat() to cutils.c
>> V2:
>>    - Introduce qemu_utimensat()
>>
>> Signed-off-by: Hidetoshi Seto<seto.hidetoshi@jp.fujitsu.com>
>>    
> 
> Applied.  Thanks.
> 
> Regards,
> 
> Anthony Liguori

Anthony,

Did you actually apply this one? I don't see it in the git tree.

However if you did, that was a mistake, the qemu_utimensat() should not
have gone into cutils.c as I pointed out earlier, it is inconsistent.

Cheers,
Jes