From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=38227 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PKQgN-0007qP-LQ for qemu-devel@nongnu.org; Mon, 22 Nov 2010 02:19:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PKQgM-00016X-8f for qemu-devel@nongnu.org; Mon, 22 Nov 2010 02:19:23 -0500 Received: from cantor.suse.de ([195.135.220.2]:58679 helo=mx1.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PKQgM-00016M-3S for qemu-devel@nongnu.org; Mon, 22 Nov 2010 02:19:22 -0500 Message-ID: <4CEA1A16.7030101@suse.de> Date: Mon, 22 Nov 2010 08:21:58 +0100 From: Hannes Reinecke MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 12/16] scsi-generic: use plain ioctl References: <20101118144736.C183DF90AB@ochil.suse.de> <20101119183901.GI32461@lst.de> <1290213698.28657.62.camel@haakon2.linux-iscsi.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: adq Cc: qemu-devel@nongnu.org, stefanha@gmail.com, Christoph Hellwig , "Nicholas A. Bellinger" , kraxel@redhat.com On 11/20/2010 02:25 AM, adq wrote: > On 20 November 2010 00:41, Nicholas A. Bellinger = wrote: >> On Fri, 2010-11-19 at 19:39 +0100, Christoph Hellwig wrote: >>> On Thu, Nov 18, 2010 at 03:47:36PM +0100, Hannes Reinecke wrote: >>>> >>>> aio_ioctl is emulated anyway and currently broken. >>> >>> What's broken about it currently? >> >> Mmmmmm, I do not recall this being broken in the first place..? There >> was a single issue with megasas+bdrv_aio_ioctl() with WinXP (that did >> not appear with lsi53c895a) that was mentioned on the list earlier in >> the year that required a patch to use bdev_ioctl(), but last I recall >> Hannes had already fixed this in recent megasas.c code w/ 32-bit MSFT >> guests. Also, this is what I have been with scsi_generic.c and >> scsi_bsg.c into TCM_loop in my v0.12.5 megasas tree, and I am not >> observing any obvious issues with AIO IOCTLs for SG_IO/BSG into Linux >> guests. >> >> I will give AIO IOCTL ops a run with these on v2.6.37-rc2 lock-less KV= M >> host mode <-> TCM_Loop to verify against the v0.12.5 megasas tree. >=20 > Could this AIO ioctl breakage perhaps be the one I fixed here? > http://web.archiveorange.com/archive/v/1XS1vROmfC7dN9wYxsmt >=20 > The patch is defintely in the latest git... it works fine for me with > my scsi-generic MMC command patches. Ah. Yes, this looks like it. I'll give it a spin; I've made the original patch against an older git rev so I might've missed that one. Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: Markus Rex, HRB 16746 (AG N=FCrnberg)