From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: stefanha@gmail.com, qemu-devel@nongnu.org, nab@linux-iscsi.org,
kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH 01/16] Allow zero alloc_hint in qemu_sglist_init()
Date: Mon, 22 Nov 2010 10:01:24 +0100 [thread overview]
Message-ID: <4CEA3164.7070209@suse.de> (raw)
In-Reply-To: <20101119182817.GB32461@lst.de>
On 11/19/2010 07:28 PM, Christoph Hellwig wrote:
> On Thu, Nov 18, 2010 at 03:44:34PM +0100, Hannes Reinecke wrote:
>>
>> qemu_malloc doesn't check for zero argument, so we need to
>> check ourselves.
>
> I'm not sure if it's a that good idea to remove the implicit
> ->sg != NULL assumption. Any reason you can't simply call
> qemu_sglist_init later?
>
We can actually drop this. It's a leftover from the old interface.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
prev parent reply other threads:[~2010-11-22 8:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 14:44 [Qemu-devel] [PATCH 01/16] Allow zero alloc_hint in qemu_sglist_init() Hannes Reinecke
2010-11-19 18:28 ` Christoph Hellwig
2010-11-22 9:01 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEA3164.7070209@suse.de \
--to=hare@suse.de \
--cc=hch@lst.de \
--cc=kraxel@redhat.com \
--cc=nab@linux-iscsi.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).