From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49671 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PKSEZ-0001rC-UN for qemu-devel@nongnu.org; Mon, 22 Nov 2010 03:58:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PKSEY-0002xW-S4 for qemu-devel@nongnu.org; Mon, 22 Nov 2010 03:58:47 -0500 Received: from cantor.suse.de ([195.135.220.2]:33370 helo=mx1.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PKSEY-0002xD-Lh for qemu-devel@nongnu.org; Mon, 22 Nov 2010 03:58:46 -0500 Message-ID: <4CEA3164.7070209@suse.de> Date: Mon, 22 Nov 2010 10:01:24 +0100 From: Hannes Reinecke MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 01/16] Allow zero alloc_hint in qemu_sglist_init() References: <20101118144434.3B68DF90AB@ochil.suse.de> <20101119182817.GB32461@lst.de> In-Reply-To: <20101119182817.GB32461@lst.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: stefanha@gmail.com, qemu-devel@nongnu.org, nab@linux-iscsi.org, kraxel@redhat.com On 11/19/2010 07:28 PM, Christoph Hellwig wrote: > On Thu, Nov 18, 2010 at 03:44:34PM +0100, Hannes Reinecke wrote: >> >> qemu_malloc doesn't check for zero argument, so we need to >> check ourselves. >=20 > I'm not sure if it's a that good idea to remove the implicit > ->sg !=3D NULL assumption. Any reason you can't simply call > qemu_sglist_init later? >=20 We can actually drop this. It's a leftover from the old interface. Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: Markus Rex, HRB 16746 (AG N=FCrnberg)