From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=46526 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PKSUV-0005Cw-Mr for qemu-devel@nongnu.org; Mon, 22 Nov 2010 04:15:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PKSUU-0006Qh-Uf for qemu-devel@nongnu.org; Mon, 22 Nov 2010 04:15:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:8847) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PKSUU-0006Ok-O0 for qemu-devel@nongnu.org; Mon, 22 Nov 2010 04:15:14 -0500 Message-ID: <4CEA3492.2040604@redhat.com> Date: Mon, 22 Nov 2010 10:14:58 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1290207997-3984-1-git-send-email-kraxel@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] ahci: fix lst+fis mapping List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel@nongnu.org On 11/21/10 03:04, Alexander Graf wrote: > > On 20.11.2010, at 00:06, Gerd Hoffmann wrote: > >> The ahci map_page() function checks whenever it got a full page >> mapped. This is wrong. The data structures are much smaller: >> command list is 1k and fis is 256 bytes. Checking whenever we can >> access that much bytes without crossing a page border is good >> enougth. > > Looks good :). Do you want me to incorporate this with the next > revision of my patch set or keep it separate? Feel free to squash it in. cheers, Gerd