From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=34071 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PKT9f-0007WY-5V for qemu-devel@nongnu.org; Mon, 22 Nov 2010 04:57:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PKT9a-0006A4-5O for qemu-devel@nongnu.org; Mon, 22 Nov 2010 04:57:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:65148) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PKT9Z-00069z-TL for qemu-devel@nongnu.org; Mon, 22 Nov 2010 04:57:42 -0500 Message-ID: <4CEA3E8E.9040508@redhat.com> Date: Mon, 22 Nov 2010 10:57:34 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <20101121191641.GA28858@redhat.com> In-Reply-To: <20101121191641.GA28858@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCHv3 RFC] qemu-kvm: stop devices on vmstop List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: jasowang@redhat.com, qemu-devel@nongnu.org, quintela@redhat.com On 11/21/10 20:16, Michael S. Tsirkin wrote: > Stop running devices on vmstop, so that VM does not interact with > outside world at that time. > > Whitelist system handlers which run even when VM is stopped. > These are specific handlers like monitor, gdbstub, migration. > I'm not really sure about ui: spice and vnc: do they need to run? Yes, vnc and spice should run. They serve the clients. They also don't change device state. cheers, Gerd PS: Well, in the spice case this isn't 100% true, the handlers can change qxl device state in some cases. But spice has a start/stop handler which takes care to flush all outstanding work which could change device state on vmstop, so it is save to keep the handlers active when the vm is in stopped state.