From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=47905 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PKUXJ-0002nj-N7 for qemu-devel@nongnu.org; Mon, 22 Nov 2010 06:26:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PKUXE-0001As-Rn for qemu-devel@nongnu.org; Mon, 22 Nov 2010 06:26:17 -0500 Received: from cantor2.suse.de ([195.135.220.15]:60265 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PKUXE-0001Aj-Mo for qemu-devel@nongnu.org; Mon, 22 Nov 2010 06:26:12 -0500 Message-ID: <4CEA53F3.5090407@suse.de> Date: Mon, 22 Nov 2010 12:28:51 +0100 From: Hannes Reinecke MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 11/16] scsi-disk: add data direction checking References: <20101118144732.99F4CF90AB@ochil.suse.de> <20101122112032.GA1579@lst.de> In-Reply-To: <20101122112032.GA1579@lst.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: stefanha@gmail.com, qemu-devel@nongnu.org, nab@linux-iscsi.org, kraxel@redhat.com On 11/22/2010 12:20 PM, Christoph Hellwig wrote: > On Thu, Nov 18, 2010 at 03:47:32PM +0100, Hannes Reinecke wrote: >> >> scsi_req_parse() already provides for a data direction setting, >> so we should be using it to check for correct direction. >=20 > Instead of just a debug printf that almost no one compiles in shouldn't > we reject the incorrect commands? >=20 Good point. Will be fixing it up for the next version. Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: Markus Rex, HRB 16746 (AG N=FCrnberg)