From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39554 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PKXmD-0001Mp-2R for qemu-devel@nongnu.org; Mon, 22 Nov 2010 09:53:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PKXm7-0006Gv-5B for qemu-devel@nongnu.org; Mon, 22 Nov 2010 09:53:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54066) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PKXm6-0006Gp-Uf for qemu-devel@nongnu.org; Mon, 22 Nov 2010 09:53:47 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oAMErkCa005116 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 22 Nov 2010 09:53:46 -0500 Message-ID: <4CEA83F8.8030500@redhat.com> Date: Mon, 22 Nov 2010 15:53:44 +0100 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects References: <1290184248-30078-1-git-send-email-Jes.Sorensen@redhat.com> <4CEA6102.3020709@redhat.com> <4CEA794F.40506@redhat.com> <4CEA7AFD.2050609@redhat.com> <4CEA7DBD.9020904@redhat.com> <4CEA806C.8040501@redhat.com> In-Reply-To: <4CEA806C.8040501@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On 11/22/10 15:38, Kevin Wolf wrote: > Am 22.11.2010 15:27, schrieb Jes Sorensen: >> On 11/22/10 15:15, Kevin Wolf wrote: >> Well ok, seems a really backwards way to try and shoot yourself in the >> foot, but ok, maybe I should redo the patch to simply allow compiling >> NBD out instead. > > You're free to dislike NBD as much as you want. Just compiling it out > unconditionally and calling it a cleanup is a bit too much. ;-) > > A configure option for disabling NBD sounds reasonable, though I'm not > sure what you're trying to achieve with it. It doesn't have any external > dependencies that you could avoid this way, does it? Well it would allow us to not build qemu-nbd and reduce the size of qemu, those are wins, albeit not that big. Cheers, Jes