From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=41645 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PKXqb-000443-Q8
	for qemu-devel@nongnu.org; Mon, 22 Nov 2010 09:58:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PKXqQ-0007DX-6P
	for qemu-devel@nongnu.org; Mon, 22 Nov 2010 09:58:25 -0500
Received: from mx1.redhat.com ([209.132.183.28]:8319)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PKXqP-0007DK-W0
	for qemu-devel@nongnu.org; Mon, 22 Nov 2010 09:58:14 -0500
Message-ID: <4CEA8501.9040603@redhat.com>
Date: Mon, 22 Nov 2010 15:58:09 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img,	so don't
	link qemu-img against NBD objects
References: <1290184248-30078-1-git-send-email-Jes.Sorensen@redhat.com>	<4CEA6102.3020709@redhat.com>
	<4CEA794F.40506@redhat.com>	<4CEA7AFD.2050609@redhat.com>
	<4CEA7DBD.9020904@redhat.com> <4CEA806C.8040501@redhat.com>
	<4CEA8437.4090900@codemonkey.ws>
In-Reply-To: <4CEA8437.4090900@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org

On 11/22/10 15:54, Anthony Liguori wrote:
> On 11/22/2010 08:38 AM, Kevin Wolf wrote:
>> You're free to dislike NBD as much as you want. Just compiling it out
>> unconditionally and calling it a cleanup is a bit too much. ;-)
>>
>> A configure option for disabling NBD sounds reasonable, though I'm not
>> sure what you're trying to achieve with it. It doesn't have any external
>> dependencies that you could avoid this way, does it?
>>    
> 
> Using block format whitelisting should be enough to disable nbd.  I
> don't see a need for an explicit --disable-nbd option.

Right, the right solution is probably to create a block driver list
argument for configure, similar to what we have for the sound drivers.

Ignore my patch.

Cheers,
Jes