From: Anthony Liguori <anthony@codemonkey.ws>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects
Date: Mon, 22 Nov 2010 09:08:53 -0600 [thread overview]
Message-ID: <4CEA8785.2030208@codemonkey.ws> (raw)
In-Reply-To: <4CEA8501.9040603@redhat.com>
On 11/22/2010 08:58 AM, Jes Sorensen wrote:
> On 11/22/10 15:54, Anthony Liguori wrote:
>
>> On 11/22/2010 08:38 AM, Kevin Wolf wrote:
>>
>>> You're free to dislike NBD as much as you want. Just compiling it out
>>> unconditionally and calling it a cleanup is a bit too much. ;-)
>>>
>>> A configure option for disabling NBD sounds reasonable, though I'm not
>>> sure what you're trying to achieve with it. It doesn't have any external
>>> dependencies that you could avoid this way, does it?
>>>
>>>
>> Using block format whitelisting should be enough to disable nbd. I
>> don't see a need for an explicit --disable-nbd option.
>>
> Right, the right solution is probably to create a block driver list
> argument for configure, similar to what we have for the sound drivers.
>
--block-drv-whitelist=
Regards,
Anthony Liguori
> Ignore my patch.
>
> Cheers,
> Jes
>
next prev parent reply other threads:[~2010-11-22 15:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 16:30 [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects Jes.Sorensen
2010-11-20 17:22 ` Andreas Färber
2010-11-20 17:39 ` Stefan Hajnoczi
2010-11-20 18:04 ` Andreas Färber
2010-11-20 18:31 ` Stefan Hajnoczi
2010-11-21 12:30 ` Jes Sorensen
2010-11-21 12:31 ` Jes Sorensen
2010-11-22 12:24 ` Kevin Wolf
2010-11-22 14:08 ` Jes Sorensen
2010-11-22 14:15 ` Kevin Wolf
2010-11-22 14:27 ` Jes Sorensen
2010-11-22 14:38 ` Kevin Wolf
2010-11-22 14:53 ` Jes Sorensen
2010-11-22 14:54 ` Anthony Liguori
2010-11-22 14:58 ` Jes Sorensen
2010-11-22 15:08 ` Anthony Liguori [this message]
2010-11-22 15:10 ` Jes Sorensen
2010-11-22 15:20 ` Anthony Liguori
2010-11-22 15:23 ` Jes Sorensen
2010-12-10 12:46 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEA8785.2030208@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=Jes.Sorensen@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).