qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Wen Congyang <wency@cn.fujitsu.com>
To: qemu-devel <qemu-devel@nongnu.org>
Cc: Luiz Capitulino <lcapitulino@redhat.com>
Subject: [Qemu-devel] [PATCH] correct migrate_set_speed's args_type
Date: Tue, 23 Nov 2010 13:41:26 +0800	[thread overview]
Message-ID: <4CEB5406.3060300@cn.fujitsu.com> (raw)

The args_type of migrate_set_speed in qmp-commands.hx is wrong.
When we set migrate speed by json, qemu will be core dumped.

Signed-off-by: Wen Congyang

---
 qmp-commands.hx |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/qmp-commands.hx b/qmp-commands.hx
index 793cf1c..16bdb08 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -495,7 +495,7 @@ EQMP
 
     {
         .name       = "migrate_set_speed",
-        .args_type  = "value:f",
+        .args_type  = "value:o",
         .params     = "value",
         .help       = "set maximum speed (in bytes) for migrations",
         .user_print = monitor_user_noop,
-- 
1.7.1

             reply	other threads:[~2010-11-23  5:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-23  5:41 Wen Congyang [this message]
2010-11-23 12:43 ` [Qemu-devel] Re: [PATCH] correct migrate_set_speed's args_type Luiz Capitulino
2010-11-23 13:31   ` Luiz Capitulino
2010-11-24  1:28     ` Wen Congyang
2010-11-24 17:48       ` Luiz Capitulino
2010-11-25  1:06         ` [Qemu-devel] [PATCH v2] " Wen Congyang
2010-11-25 13:29           ` [Qemu-devel] " Luiz Capitulino
2010-12-10 15:20     ` [Qemu-devel] Re: [PATCH] " Markus Armbruster
2010-12-10 15:33       ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CEB5406.3060300@cn.fujitsu.com \
    --to=wency@cn.fujitsu.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).