From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=52125 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PLCRQ-00012z-Pc for qemu-devel@nongnu.org; Wed, 24 Nov 2010 05:19:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PLCMM-00009j-OB for qemu-devel@nongnu.org; Wed, 24 Nov 2010 05:14:31 -0500 Received: from cantor2.suse.de ([195.135.220.15]:51385 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PLCMM-00008r-FF for qemu-devel@nongnu.org; Wed, 24 Nov 2010 05:13:54 -0500 Message-ID: <4CECE609.7080600@suse.de> Date: Wed, 24 Nov 2010 11:16:41 +0100 From: Hannes Reinecke MIME-Version: 1.0 References: <1290586723-8724-1-git-send-email-nab@linux-iscsi.org> <4CECD36E.50401@suse.de> <4CECD50F.9060501@redhat.com> In-Reply-To: <4CECD50F.9060501@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Stefan Hajnoczi , qemu-devel , "Nicholas A. Bellinger" , Gerd Hoffmann , Paolo Bonzini , linux-iscsi-target-dev@googlegroups.com On 11/24/2010 10:04 AM, Kevin Wolf wrote: > Am 24.11.2010 09:57, schrieb Hannes Reinecke: >> On 11/24/2010 09:18 AM, Nicholas A. Bellinger wrote: >>> From: Nicholas Bellinger >>> >>> This patch adds a handful of bugfixes for scsi-generic >>> that where added into: >>> >>> commit a4194b3f79a85e111f000788ddec05d465748851 >>> Author: Hannes Reinecke >>> Date: Mon Nov 22 15:39:33 2010 -0800 >>> >>> scsi: Use 'SCSIRequest' directly >>> >>> this includes: >>> >>> *) Fix incorrect errno usage in switch() statement within >>> scsi_command_complete() >>> >>> *) Remove bogus scsi_command_complete() for residual case >>> within scsi_read_complete() >>> >>> *) Remove incorrect '-' sign from return in scsi_send_command() >>> >>> Tested with .37-rc2 TCM_Loop FILEIO backstores on KVM host into >>> Debian Lenny v2.6.26 KVM guest with an xfs filesystem mount. >>> >>> Signed-off-by: Nicholas A. Bellinger nab@linux-iscsi.org> >=20 > Hannes, can you fold the necessary parts of this into the next version > of your series, so that we don't break things first and fix them only l= ater? >=20 I'll be folding the first one into my series. The second one is actually a genuine error, and a rather old one to boot. It went in with this commit: commit 89c0f6438d16ebceccdcd096bbc0b5536146a443 Author: aurel32 Date: Fri Oct 17 08:08:56 2008 +0000 Subject: scsi-generic: correct error management So I'd rather have it submitted separately. And a second opinion is _definitely_ required here. nab, can you do the honours? The third is bogus anyway. Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: Markus Rex, HRB 16746 (AG N=FCrnberg)