From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59669 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PLCjq-0008Rs-Ps
	for qemu-devel@nongnu.org; Wed, 24 Nov 2010 05:38:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PLCfD-0000ga-Ki
	for qemu-devel@nongnu.org; Wed, 24 Nov 2010 05:33:57 -0500
Received: from mx1.redhat.com ([209.132.183.28]:35991)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PLCfD-0000gN-Ca
	for qemu-devel@nongnu.org; Wed, 24 Nov 2010 05:33:23 -0500
Message-ID: <4CECEA2A.40008@redhat.com>
Date: Wed, 24 Nov 2010 11:34:18 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1290586723-8724-1-git-send-email-nab@linux-iscsi.org>
	<4CECD36E.50401@suse.de> <4CECD50F.9060501@redhat.com>
	<4CECE609.7080600@suse.de>
In-Reply-To: <4CECE609.7080600@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest'
	conversion
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hannes Reinecke <hare@suse.de>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel <qemu-devel@nongnu.org>, "Nicholas A. Bellinger" <nab@linux-iscsi.org>, Gerd Hoffmann <kraxel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, linux-iscsi-target-dev@googlegroups.com

Am 24.11.2010 11:16, schrieb Hannes Reinecke:
> The second one is actually a genuine error, and a rather old one to
> boot. It went in with this commit:
> 
> commit 89c0f6438d16ebceccdcd096bbc0b5536146a443
> Author: aurel32 <aurel32@c046a42c-6fe2-441c-8c8c-71466251a162>
> Date:   Fri Oct 17 08:08:56 2008 +0000
> Subject: scsi-generic: correct error management
> 
> So I'd rather have it submitted separately.
> And a second opinion is _definitely_ required here.
> nab, can you do the honours?

The commit message of this commit says it's a workaround for a problem
with lsi:

> - when a read is aborted due to a mark/EOF/EOD/EOM, the len reported to
> controller can be 0. LSI controller emulation doesn't know how to manage
> this. A workaround found is to call the completion routine with
> SCSI_REASON_DONE just after calling it with SCSI_REASON_DATA with len=0.

Are you sure that it's not needed any more?

Kevin