From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=51217 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PLCpT-0002B7-0R for qemu-devel@nongnu.org; Wed, 24 Nov 2010 05:44:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PLCpQ-0006Nf-Js for qemu-devel@nongnu.org; Wed, 24 Nov 2010 05:43:58 -0500 Received: from cantor.suse.de ([195.135.220.2]:59316 helo=mx1.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PLCpQ-0006Mw-CP for qemu-devel@nongnu.org; Wed, 24 Nov 2010 05:43:56 -0500 Message-ID: <4CECED12.5020109@suse.de> Date: Wed, 24 Nov 2010 11:46:42 +0100 From: Hannes Reinecke MIME-Version: 1.0 References: <1290586723-8724-1-git-send-email-nab@linux-iscsi.org> <4CECD36E.50401@suse.de> <4CECD50F.9060501@redhat.com> <4CECE609.7080600@suse.de> <4CECEA2A.40008@redhat.com> In-Reply-To: <4CECEA2A.40008@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Nicholas A. Bellinger" Cc: Kevin Wolf , Stefan Hajnoczi , qemu-devel , Gerd Hoffmann , Paolo Bonzini , linux-iscsi-target-dev@googlegroups.com On 11/24/2010 11:34 AM, Kevin Wolf wrote: > Am 24.11.2010 11:16, schrieb Hannes Reinecke: >> The second one is actually a genuine error, and a rather old one to >> boot. It went in with this commit: >> >> commit 89c0f6438d16ebceccdcd096bbc0b5536146a443 >> Author: aurel32 >> Date: Fri Oct 17 08:08:56 2008 +0000 >> Subject: scsi-generic: correct error management >> >> So I'd rather have it submitted separately. >> And a second opinion is _definitely_ required here. >> nab, can you do the honours? >=20 > The commit message of this commit says it's a workaround for a problem > with lsi: >=20 >> - when a read is aborted due to a mark/EOF/EOD/EOM, the len reported t= o >> controller can be 0. LSI controller emulation doesn't know how to mana= ge >> this. A workaround found is to call the completion routine with >> SCSI_REASON_DONE just after calling it with SCSI_REASON_DATA with len=3D= 0. >=20 > Are you sure that it's not needed any more? >=20 Don't ask me. I didn't do the patch, and my knowledge of lsi HBA internals is scanty. Nic, can you comment here? Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: Markus Rex, HRB 16746 (AG N=FCrnberg)