From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=52866 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PLNAs-0005NT-33 for qemu-devel@nongnu.org; Wed, 24 Nov 2010 16:46:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PLNAp-0003Q6-Ac for qemu-devel@nongnu.org; Wed, 24 Nov 2010 16:46:45 -0500 Received: from moutng.kundenserver.de ([212.227.17.10]:55963) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PLNAo-0003Pm-UZ for qemu-devel@nongnu.org; Wed, 24 Nov 2010 16:46:43 -0500 Message-ID: <4CED87BA.7000609@mail.berlios.de> Date: Wed, 24 Nov 2010 22:46:34 +0100 From: Stefan Weil MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PULL] More format checking List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Anthony Liguori , QEMU Developers , =?ISO-8859-15?Q?Andreas_F=E4rber?= Hello, with these patches, hopefully all functions with printf like arguments use gcc's format checking, so the TODO comment in HACKING can be removed. The patch series was tested with a default build configuration on linux and windows hosts (including some cross compilations for arm, mips and powerpc), so chances are good that there remain few (if any) functions without format checking. If there remain such functions (and maybe also some related format bugs), the compiler will raise a warning now, so it should be easy to fix them. All patches were published on qemu-devel. There were two replies: * 1st patch: small typo in commit message, fixed now * last patch: breaks build It's normal that the last patch will break builds with warning = error as long as the other four patches (and maybe more format related fixes) are not applied. This is the intention of the last patch! Regards, Stefan Weil The following changes since commit f711df67d611e4762966a249742a5f7499e19f99: microblaze: target-ify target_ucontext (2010-11-23 10:04:30 +0100) are available in the git repository at: git://git.weilnetz.de/git/qemu for-blueswirl Stefan Weil (5): *-dis: Replace fprintf_ftype by fprintf_function (format checking) target-sparc: Use fprintf_function (format checking) audio: Use GCC_FMT_ATTR (format checking) darwin-user: Use GCC_FMT_ATTR (format checking) configure: Add compiler option -Wmissing-format-attribute HACKING | 3 --- alpha-dis.c | 3 +++ arm-dis.c | 14 +++++++------- audio/audio_pt_int.c | 3 ++- configure | 1 + darwin-user/machload.c | 2 +- darwin-user/qemu.h | 2 +- dis-asm.h | 10 ++-------- m68k-dis.c | 2 +- microblaze-dis.c | 2 +- mips-dis.c | 2 -- sh4-dis.c | 16 +++++----------- target-sparc/cpu.h | 4 ++-- 13 files changed, 26 insertions(+), 38 deletions(-)