From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=54107 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PN1VT-0008Br-34 for qemu-devel@nongnu.org; Mon, 29 Nov 2010 06:02:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PN1VR-0007E5-UM for qemu-devel@nongnu.org; Mon, 29 Nov 2010 06:02:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48220) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PN1VR-0007E0-ML for qemu-devel@nongnu.org; Mon, 29 Nov 2010 06:02:49 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oATB2mcC030286 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 29 Nov 2010 06:02:48 -0500 Message-ID: <4CF38855.90109@redhat.com> Date: Mon, 29 Nov 2010 12:02:45 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1289479772-19961-1-git-send-email-kraxel@redhat.com> <20101112135834.63129825@doriath> <4CEE4BBC.5050204@redhat.com> <20101129100320.GA2528@redhat.com> In-Reply-To: <20101129100320.GA2528@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [RfC PATCH] spice: qmp windup: connection events & info command. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, Luiz Capitulino Hi, >> Doesn't make that much sense IMHO as the both provide quite simliar >> informations (i.e. "info spice" gives you a list of connections with >> pretty much the same info provided by the events). > > If you are wanting to record/log incoming connections, then you > can't use 'info spice' to get the details, because between the > time of getting the event notification of the new client and > calling 'info spice' to get the client details, the client can > have disconnected. Thus all the info needs to be provided in the > event, even if it is also available in 'info spice'. This is the > same as with VNC events. Sure. All the info is given in both cases, thats why there is quite some code sharing ;) I'll go split the patch nevertheless, with the doc updates added it indeed makes sense. "info spice" can be used to figure the connections which did already exist before management connected to qmp. Later on just processing the events gives you all informations you need. cheers, Gerd