From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=44568 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PNfRK-0000GX-Uu
	for qemu-devel@nongnu.org; Wed, 01 Dec 2010 00:41:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1PNKQr-0003rE-DM
	for qemu-devel@nongnu.org; Tue, 30 Nov 2010 02:15:22 -0500
Received: from lo.gmane.org ([80.91.229.12]:60308)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1PNKQr-0003qr-4U
	for qemu-devel@nongnu.org; Tue, 30 Nov 2010 02:15:21 -0500
Received: from list by lo.gmane.org with local (Exim 4.69)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1PNKQk-00066i-6B
	for qemu-devel@nongnu.org; Tue, 30 Nov 2010 08:15:14 +0100
Received: from s209p8.home.99maxprogres.cz ([85.93.118.17])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Tue, 30 Nov 2010 08:15:14 +0100
Received: from pbonzini by s209p8.home.99maxprogres.cz with local (Gmexim 0.1
	(Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Tue, 30 Nov 2010 08:15:14 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Tue, 30 Nov 2010 08:15:04 +0100
Message-ID: <4CF4A478.8080209@redhat.com>
References: <cover.1290552026.git.quintela@redhat.com>	<9b23b9b4cee242591bdb356c838a9cfb9af033c1.1290552026.git.quintela@redhat.com>
	<4CF45D67.5010906@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
In-Reply-To: <4CF45D67.5010906@codemonkey.ws>
Subject: [Qemu-devel] Re: [PATCH 09/10] Exit loop if we have been there too
	long
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Juan Quintela <quintela@trasno.org>, Juan Quintela <quintela@redhat.com>

On 11/30/2010 03:11 AM, Anthony Liguori wrote:
>
> BufferedFile should hit the qemu_file_rate_limit check when the socket
> buffer gets filled up.

The problem is that the file rate limit is not hit because work is done 
elsewhere.  The rate can limit the bandwidth used and makes QEMU aware 
that socket operations may block (because that's what the buffered file 
freeze/unfreeze logic does); but it cannot be used to limit the _time_ 
spent in the migration code.

Paolo