From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=53435 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PNdPQ-0002Mx-4n for qemu-devel@nongnu.org; Tue, 30 Nov 2010 22:31:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PNZV4-0003tz-MB for qemu-devel@nongnu.org; Tue, 30 Nov 2010 18:20:43 -0500 Received: from e37.co.us.ibm.com ([32.97.110.158]:43299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PNZV4-0003s6-Cg for qemu-devel@nongnu.org; Tue, 30 Nov 2010 18:20:42 -0500 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e37.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id oAUNIHwM019318 for ; Tue, 30 Nov 2010 16:18:17 -0700 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id oAUNKZuJ159592 for ; Tue, 30 Nov 2010 16:20:35 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id oAUNKYEm031943 for ; Tue, 30 Nov 2010 16:20:34 -0700 Message-ID: <4CF586C1.4070405@linux.vnet.ibm.com> Date: Tue, 30 Nov 2010 15:20:33 -0800 From: "Venkateswararao Jujjuri (JV)" MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/6] Move paio_cancel() to new infrastructure. References: <20101118180547.4434.95904.stgit@localhost6.localdomain6> <20101118180655.4434.23045.stgit@localhost6.localdomain6> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, Arun R Bharadwaj , qemu-devel@nongnu.org On 11/19/2010 2:07 AM, Stefan Hajnoczi wrote: > On Thu, Nov 18, 2010 at 6:06 PM, Arun R Bharadwaj > wrote: >> Move paio_cancel() to new infrastructure and introduce >> the necessary APIs for this. >> >> Signed-off-by: Arun R Bharadwaj >> --- >> posix-aio-compat.c | 92 ++++++++++++++++++++++++++++++++++++++++++---------- >> 1 files changed, 74 insertions(+), 18 deletions(-) > > This commit is not a safe step to make. paio_cancel() is going to > cause uninitialized threadlet structures to be accessed. > > You split the patches up into smaller commits for easier review. > Unfortunately this particular commit will result in a QEMU which > builds successfully but has undefined behavior at runtime - it may > crash or do random things. > > That's a problem for git-bisect(1) and in general for anyone who > assumes they can build QEMU at an arbitrary point in the commit > history. It's really important to preserve bisectability, because > once commits get introduced that build bad QEMUs we can no longer have > confidence in bisect! > > Please split up commits so they introduce a new feature incrementally > but work properly at each step in the series. Arun, you may move this to later part of the series to take care of this bisect issue. Thanks, JV > > Stefan >