From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45879 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PNmYh-0006Vr-G3
	for qemu-devel@nongnu.org; Wed, 01 Dec 2010 08:17:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PNmYg-0004XB-F5
	for qemu-devel@nongnu.org; Wed, 01 Dec 2010 08:17:19 -0500
Received: from mx1.redhat.com ([209.132.183.28]:35632)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PNmYg-0004Wl-7Y
	for qemu-devel@nongnu.org; Wed, 01 Dec 2010 08:17:18 -0500
Message-ID: <4CF64AEC.1030602@redhat.com>
Date: Wed, 01 Dec 2010 14:17:32 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1290799053-27282-1-git-send-email-agraf@suse.de>	<1290799053-27282-4-git-send-email-agraf@suse.de>
	<AANLkTikv2JgjaptikwfhOuPegszc0y2ZRR4bC9Oiyb5s@mail.gmail.com>
In-Reply-To: <AANLkTikv2JgjaptikwfhOuPegszc0y2ZRR4bC9Oiyb5s@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 03/13] ide: add support for ide bus ops
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Joerg Roedel <Joerg.Roedel@amd.com>, Paul Brook <paul@codesourcery.com>, Alexander Graf <agraf@suse.de>, QEMU-devel Developers <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>, Gerd Hoffmann <kraxel@redhat.com>, tj@kernel.org, Sebastian Herbszt <herbszt@gmx.de>, Roland Elek <elek.roland@gmail.com>

Am 01.12.2010 14:09, schrieb Stefan Hajnoczi:
> On Fri, Nov 26, 2010 at 7:17 PM, Alexander Graf <agraf@suse.de> wrote:
> Just some cosmetic suggestions.
> 
>> @@ -2716,6 +2736,12 @@ static void ide_init1(IDEBus *bus, int unit)
>>                                            ide_sector_write_timer_cb, s);
>>  }
>>
>> +static IDEBusOps ide_bus_ops = {
> 
> Since the functions are all pata_* I think it makes sense for this to
> be called pata_bus_ops, not ide_bus_ops.
> 
>> +    .transfer_start_fn = pata_transfer_start,
>> +    .irq_set_fn = pata_set_irq,
> 
> irq_set or set_irq? :)  Let's consistently go with set_irq.

And drop the _fn suffix? It's really obvious that these are functions
(if this is what it's meant to say).

Kevin