From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=49408 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PNnOb-0001uo-1D
	for qemu-devel@nongnu.org; Wed, 01 Dec 2010 09:10:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PNnOZ-0006nj-5Y
	for qemu-devel@nongnu.org; Wed, 01 Dec 2010 09:10:56 -0500
Received: from mail-gx0-f173.google.com ([209.85.161.173]:54167)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PNnOZ-0006nV-2z
	for qemu-devel@nongnu.org; Wed, 01 Dec 2010 09:10:55 -0500
Received: by gxk24 with SMTP id 24so3675294gxk.4
	for <qemu-devel@nongnu.org>; Wed, 01 Dec 2010 06:10:54 -0800 (PST)
Message-ID: <4CF65769.2080807@codemonkey.ws>
Date: Wed, 01 Dec 2010 08:10:49 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2 0/3] vnc/spice: add monitor commands to
	change+expire passwords.
References: <1291123379-3101-1-git-send-email-kraxel@redhat.com>
In-Reply-To: <1291123379-3101-1-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On 11/30/2010 07:22 AM, Gerd Hoffmann wrote:
>    Hi,
>
> This patch series adds new monitor commands to set and expire
> the password:
>
>    set-password $protocol $secret
>    expire-password $protocol [ now | never | +secs | secs ]
>
> The time when the password expires can be specified either relative
> (+60 == password expires in 60 seconds from now) or absolute in seconds
> since 1970 aka unix-epoch.
>    

In the server TZ?  That's pretty nasty if you don't have a mechanism to 
figure out what the server TZ is.

Unless you have a strong desire to keep it, I would just drop the 
absolute bit.

Regards,

Anthony Liguori

> Check the patches and/or updated docs for details.
>
> cheers,
>    Gerd
>
> [ v2: remove tabs ]
>
> Gerd Hoffmann (3):
>    vnc: auth reject cleanup
>    vnc: support password expire
>    vnc/spice: add set_passwd monitor command.
>
>   console.h       |    1 +
>   hmp-commands.hx |   54 +++++++++++++++++++++++++++++
>   monitor.c       |  100 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   qemu-common.h   |    3 ++
>   qmp-commands.hx |   57 +++++++++++++++++++++++++++++++
>   ui/qemu-spice.h |    5 +++
>   ui/spice-core.c |   35 +++++++++++++++++++
>   ui/vnc.c        |   44 +++++++++++++++---------
>   ui/vnc.h        |    1 +
>   9 files changed, 283 insertions(+), 17 deletions(-)
>
>
>